more small fixes

rerun-io · Dec 19, 2024 · 97cc07c · 97cc07c
1 parent b5c13a9
commit 97cc07c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/crates/store/re_log_encoding/src/codec/wire/encoder.rs b/crates/store/re_log_encoding/src/codec/wire/encoder.rs
@@ -5,7 +5,7 @@ use re_chunk::TransportChunk;
 /// Encode a transport chunk into a byte stream.
 pub fn encode(
     version: re_protos::common::v0::EncoderVersion,
-    chunk: TransportChunk,
+    chunk: &TransportChunk,
 ) -> Result<Vec<u8>, CodecError> {
     match version {
         re_protos::common::v0::EncoderVersion::V0 => {

diff --git a/crates/store/re_log_encoding/src/codec/wire/mod.rs b/crates/store/re_log_encoding/src/codec/wire/mod.rs
@@ -7,7 +7,7 @@ pub use encoder::encode;
 #[cfg(test)]
 mod tests {
     use crate::{
-        codec::wire::{decode, encode, TransportMessageV0},
+        codec::wire::{decode, encode},
         codec::CodecError,
     };
     use re_chunk::{Chunk, RowId};
@@ -38,9 +38,9 @@ mod tests {
     }
 
     #[test]
-    fn test_invalid_batch_data() {
-        let data = vec![2, 3, 4]; // '1' is NO_DATA message header
-        let decoded = TransportMessageV0::from_bytes(&data);
+    fn test_invalid_data() {
+        let data = vec![2, 3, 4];
+        let decoded = decode(EncoderVersion::V0, &data);
 
         assert!(matches!(
             decoded.err().unwrap(),
@@ -54,7 +54,7 @@ mod tests {
 
         let encoded = encode(
             EncoderVersion::V0,
-            expected_chunk.clone().to_transport().unwrap(),
+            &expected_chunk.clone().to_transport().unwrap(),
         )
         .unwrap();
         let decoded = decode(EncoderVersion::V0, &encoded).unwrap();

diff --git a/rerun_py/src/remote.rs b/rerun_py/src/remote.rs
@@ -269,7 +269,7 @@ impl PyStorageNodeClient {
 
                     let metadata_tc = TransportChunk::from_arrow_record_batch(&metadata);
 
-                    encode(EncoderVersion::V0, metadata_tc)
+                    encode(EncoderVersion::V0, &metadata_tc)
                         .map_err(|err| PyRuntimeError::new_err(err.to_string()))
                 })
                 .transpose()?
@@ -339,7 +339,7 @@ impl PyStorageNodeClient {
             let request = UpdateCatalogRequest {
                 metadata: Some(DataframePart {
                     encoder_version: EncoderVersion::V0 as i32,
-                    payload: encode(EncoderVersion::V0, metadata_tc)
+                    payload: encode(EncoderVersion::V0, &metadata_tc)
                         .map_err(|err| PyRuntimeError::new_err(err.to_string()))?,
                 }),
             };