Skip to content

Commit

Permalink
Hide outline rectangle around views (#8507)
Browse files Browse the repository at this point in the history
* Closes #8494

Removes the highlighted rectangle around views that are hovered or
selected.
Why? Because we already have the tab title for this.

Keeps it for containers, because they have no tab title.



https://github.com/user-attachments/assets/bb407161-f3a8-4c66-bbd9-816f8dd28561
  • Loading branch information
emilk authored Dec 17, 2024
1 parent 0a5fe08 commit 57b45e7
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions crates/viewer/re_viewport/src/viewport_ui.rs
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,13 @@ impl ViewportUi {
continue;
};

if matches!(contents, Contents::View(_))
&& !should_display_drop_destination_frame
{
// We already light up the view tab title; that is enough
continue;
}

// We want the rectangle to be on top of everything in the viewport,
// including stuff in "zoom-pan areas", like we use in the graph view.
let top_layer_id =
Expand Down

0 comments on commit 57b45e7

Please sign in to comment.