Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data model: adapt JONSchemas to angular 17 #991

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from
Draft

data model: adapt JONSchemas to angular 17 #991

wants to merge 2 commits into from

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 24, 2024

No description provided.

@PascalRepond
Copy link
Contributor

PO tests

  • Admin interface: Everything looks about 10% smaller (fonts, navbar, margins, buttons etc)
  • Some buttons are squared instead of rounded
    • Submit a deposit: "Explore files"
    • Editors + brief views + detailed views: shortlist to add fields, "save", "cancel", "delete", "select fields"
    • Search button (pro UI)
    • Deposit editor: "import metadata" "save", buttons to switch between JSON/eidtor view
    • Deposits brief view "history"
  • Deposit a document editor: The circle with steps are not centered
    image
  • Deposit editor: certain fields are offset to the right
    image
  • When I save a subdivision/user: I am redirected to the home page (since there is no detailed view). Would be better to redirect to brief view
  • Document files detailed view (Edit files):
    • I can save a file as "embargoed" without sepcifying a date (the date should be required)
    • When switching a file to "embargoed", "access from the organisation" should be unchecked by default
    • Order buttons: shouldn't the upper double-arrow be at the top?
  • Doc detailed view: first tab, display bug when document has no files
  • Also the "Uploaded files" box could be hidden if the document has no files
    image

@jma
deployment: fix docker file
ad3310a 
* Fixes lxml conflict with uwsgi command for the deployment.
* Adds safety exceptions.
* Fixes some small cosmetics in the JSONSchemas.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jma @PascalRepond