feat: file transfer from reroils-data #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
requested changes
Sep 5, 2018
| @@ -42,6 +42,7 @@ htmlcov/ | |||
| .coverage | |||
| .coverage.* | |||
| .cache | |||
| .pytest_cache | |||
There was a problem hiding this comment.
It was always on git status
| recursive-include docs *.bat | ||
| recursive-include docs *.py | ||
| recursive-include docs *.rst | ||
| recursive-include docs *.txt | ||
| recursive-include docs Makefile | ||
| recursive-include rero_mef *.gitkeep |
There was a problem hiding this comment.
Comes from check-manifest -u
| # ----------------------------------- Classes --------------------------------- | ||
|
|
||
| # MrcIterator ---- | ||
| class Transformation(object): |
There was a problem hiding this comment.
- BnfTransformation instead? If yes do the same for the others.
- Create a base class for the common methods.
| self.logger = logger | ||
| self.verbose = verbose | ||
| self.json_dict = {} | ||
| if transform: |
There was a problem hiding this comment.
Why? More generally we can have a class method such as: set_marc(marc) that do the transformation and a cached property for json.
|
|
||
| # ----------------------------------- Classes --------------------------------- | ||
| # MrcIterator ---- | ||
| class Transformation(object): |
| } | ||
|
|
||
|
|
||
| def test_bnf_language_of_perso_2(): |
There was a problem hiding this comment.
Comes from baa et pag
| assert trans.json == {} | ||
|
|
||
|
|
||
| def test_gnd_language_of_person_1(): |
There was a problem hiding this comment.
Comes from baa et pag
|
|
||
|
|
||
| def test_gnd_language_of_person_1(): | ||
| """Test language of person 377 $a (langue sur 3 caractères) ISO 639-2b""" |
There was a problem hiding this comment.
Comes from baa et pag
| } | ||
|
|
||
|
|
||
| def test_gnd_language_of_person_2(): |
There was a problem hiding this comment.
Comes from baa et pag
| @@ -24,13 +24,13 @@ | |||
|
|
|||
| """Views tests.""" | |||
|
|
|||
| from __future__ import absolute_import, print_function | |||
There was a problem hiding this comment.
It's from the cookiecutter, You have to ask invenio.
Signed-off-by: Peter Weber <[email protected]> Co-authored-by: Bertrand Zuchuat <[email protected]>
rerowep
force-pushed
the
wep-#645-file-transfer-from-data
branch
from
59f6029
to
589b070
Compare
jma
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Weber [email protected]
Co-authored-by: Bertrand Zuchuat [email protected]
Verify:
all nedded files from https://github.com/rero/reroils-data-legacy/tree/auth-master have been transferred
Test:
./scripts/bootstrap
./run_tests.ch