Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No thumbnail loaded for documents with any "electronicLocator" #3755

Closed
PascalRepond opened this issue Sep 23, 2024 · 0 comments · Fixed by rero/rero-ils-ui#1205
Closed

No thumbnail loaded for documents with any "electronicLocator" #3755

PascalRepond opened this issue Sep 23, 2024 · 0 comments · Fixed by rero/rero-ils-ui#1205
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries UX User experience, ergonomy

Comments

@PascalRepond
Copy link
Contributor

Bug description:

If a document has a field "electornicLocator" of any kind, this prevents the thumbnail to be loaded from the thumbnail service.

Expected behavior:

Only an "electronicLocator" of type "relatedResource" with value "coverImage" should replace the thumbnail service.

Steps to Reproduce:

  1. Edit any document with a thumbnail
  2. Add a field "electronicLocator"
  3. See that the thumbnail is not loaded anymore
@PascalRepond PascalRepond added bug Breaks something but is not blocking UX User experience, ergonomy client request Issue reported by production libraries labels Sep 23, 2024
@PascalRepond PascalRepond mentioned this issue Sep 23, 2024
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Sep 23, 2024
@Garfield-fr
fix(thumbnail): display by isbn if no link
b94adc7 
Display thumbnail by isbn, if no thumbnail link is available
in the electronicLocator field.

* Closes rero/rero-ils#3755.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Sep 25, 2024
@Garfield-fr
fix(thumbnail): display by isbn if no link
ab7ca5d 
Display thumbnail by isbn, if no thumbnail link is available
in the electronicLocator field.

* Closes rero/rero-ils#3755.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from Inbox to Done in RERO ILS issues Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries UX User experience, ergonomy
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(thumbnail): display by isbn if no link Garfield-fr/rero-ils-ui
1 participant
@PascalRepond