Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvested physical books are not displayed correctly in public UI #3738

Closed
PascalRepond opened this issue Aug 27, 2024 · 0 comments · Fixed by #3741
Closed

Harvested physical books are not displayed correctly in public UI #3738

PascalRepond opened this issue Aug 27, 2024 · 0 comments · Fixed by #3741
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface

Comments

@PascalRepond
Copy link
Contributor

Bug description:

When harvesting lists of books (for example Bibliomedia), we need to set them as "harvested:true" so that they cannot be edited (see #3147). However, those are not displayed correctly in the public UI.

image001

Expected behavior:

Even though they are harvested, these documents should display standard holdings-issues and not electronic issues.

Steps to Reproduce:

  1. Load a document with an item as "harvested:true"
  2. Go to the document public detailed view
  3. See that the item is not displayed.
@PascalRepond PascalRepond added f: public ui Public interface, as opposed to the professional interface bug Breaks something but is not blocking labels Aug 27, 2024
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Aug 29, 2024
@PascalRepond
fix(public document view): allow harvested documents with physical items
ca01aec 
* Closes rero#3738.

Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond mentioned this issue Aug 29, 2024
Merged
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Aug 29, 2024
@PascalRepond
fix(public document view): allow harvested documents with physical items
916d8b2 
* Closes rero#3738.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Aug 29, 2024
@PascalRepond
fix(public document view): allow harvested documents with physical items
4087208 
* Closes rero#3738.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Aug 29, 2024
@PascalRepond
fix(public document view): allow harvested documents with physical items
7a12ba7 
* Closes rero#3738.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Sep 2, 2024
@PascalRepond
fix(public document view): allow harvested documents with physical items
358833b 
* Closes rero#3738.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit that referenced this issue Sep 3, 2024
@PascalRepond
fix(public document view): allow harvested documents with physical items
8c11eed 
* Closes #3738.

Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond moved this from In Development to Ready to test in RERO ILS issues Sep 3, 2024
PascalRepond added a commit that referenced this issue Sep 17, 2024
@PascalRepond
fix(public document view): allow harvested documents with physical items
583105f 
* Closes #3738.

Co-Authored-by: Pascal Repond <[email protected]>
@github-project-automation github-project-automation bot moved this from In testing to Done in RERO ILS issues Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: public ui Public interface, as opposed to the professional interface
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(public document view): allow harvested documents with physical items PascalRepond/rero-ils
1 participant
@PascalRepond