Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document import: subject creator is unexpected #3468

Closed
PascalRepond opened this issue Sep 25, 2023 · 1 comment · Fixed by #3460
Closed

Document import: subject creator is unexpected #3468

PascalRepond opened this issue Sep 25, 2023 · 1 comment · Fixed by #3460
Labels
bug Breaks something but is not blocking

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Sep 25, 2023 •
edited
Loading

Bug description:

When importing a document with a subject of type Work that has a creator (MARC subfield ?), the importer tries to create a subfield subjects_imported.entity.creator that is not accepted by the jsonschema. This creates an error when trying to save the document.

Relates to

  • Sentry: RERO-ILS-53M
  • RT: 623

Expected behavior:

In this case, the document importer should create a unique authorized_access_point from the MARC fields without creating an invalid "creator" subfield in the json.

Format of the authorized access point : TO BE DEFINED

Steps to Reproduce:

  1. Try to import this document from SLSP : https://ils.test.rero.ch/professional/records/documents/new?source=slsp&pid=991171187128205501
  2. Check "network" inspector and see the incorrect json
  3. Try to save and see the error

Version:

v1.18.0

Anything else?

⚠️ : Check that other importer versions (LoC, etc...) also avoid this error.
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Sep 25, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Sep 25, 2023
@PascalRepond PascalRepond changed the title Subject import: creator is unexpected Document import: subject creator is unexpected Sep 25, 2023
@PascalRepond
Copy link
Contributor Author

Exact specifications for work subjects imports should be clarified between @rerowep and @Ewa666

@PascalRepond PascalRepond moved this from Product Backlog to In Development in RERO ILS issues Oct 3, 2023
rerowep added a commit to rerowep/rero-ils that referenced this issue Oct 3, 2023
@rerowep
import: fix import SLSP
12e170d 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Oct 3, 2023
@rerowep
import: fix import SLSP
62b417a 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Oct 3, 2023
@rerowep
import: fix import SLSP
76ebe6c 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Oct 3, 2023
@rerowep
import: fix import SLSP
7cfecf5 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
@PascalRepond PascalRepond mentioned this issue Oct 3, 2023
Merged
rerowep added a commit to rerowep/rero-ils that referenced this issue Oct 3, 2023
@rerowep
import: fix import SLSP
e79feb1 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Oct 3, 2023
@rerowep
import: fix import SLSP
8b4605d 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Oct 3, 2023
@rerowep
import: fix import SLSP
084bf40 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Oct 3, 2023
@rerowep
import: fix import SLSP
097d88b 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes rero#3468.

Co-Authored-by: Peter Weber <[email protected]>
@PascalRepond PascalRepond moved this from In Development to Ready to test in RERO ILS issues Oct 4, 2023
Garfield-fr pushed a commit that referenced this issue Oct 4, 2023
@rerowep @Garfield-fr
import: fix import SLSP
b692fdb 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes #3468.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit that referenced this issue Oct 9, 2023
@rerowep
import: fix import SLSP
cecd63a 
* Make SLSP import more robust against wrong MARC21 for example
  019 has no subfields.
* Adds $ref creation for different entity types.
* Closes #3468.

Co-Authored-by: Peter Weber <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

import: fix import SLSP rerowep/rero-ils
1 participant
@PascalRepond