Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error sending an order when the language template is not configured #2714

Closed
ManaDeweerdt opened this issue Feb 18, 2022 · 0 comments · Fixed by #3465
Closed

Error sending an order when the language template is not configured #2714

ManaDeweerdt opened this issue Feb 18, 2022 · 0 comments · Fixed by #3465
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking effort: minor Solved quickly f: acquisitions Related to the acquisition module

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Feb 18, 2022 •
edited
Loading

Describe the bug

We get an error message when we try to send an order and the the vendor_order_mail template is not configured or the communication language field of the vendor is empty.

See also : #3214

To Reproduce

  1. Create a new provider without a communication language.
  2. Create an new order and try to send it.
  3. See error

Expected behavior

Make the field 'communication language' mandatory or use a language by default sending an order.

Context

Screenshots

image

Additional context
@ManaDeweerdt ManaDeweerdt added bug Breaks something but is not blocking f: acquisitions Related to the acquisition module p-Low Low priority labels Feb 18, 2022
@ManaDeweerdt ManaDeweerdt changed the title Error sending an order when the profiler's communication language is not configured Error sending an order when the language template is not configured Mar 11, 2022
@ManaDeweerdt ManaDeweerdt mentioned this issue Jan 19, 2023
Open
@PascalRepond PascalRepond added the effort: minor Solved quickly label Mar 8, 2023
@PascalRepond PascalRepond removed the p-Low Low priority label Mar 30, 2023
@PascalRepond PascalRepond moved this to Product Backlog in RERO ILS issues Mar 30, 2023
Garfield-fr added a commit that referenced this issue Sep 21, 2023
@Garfield-fr
Acquisition: fix default vendor language
09f575d 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes #2714.
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 21, 2023
@Garfield-fr
Acquisition: fix default vendor language
879c4c2 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes rero#2714.
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 21, 2023
@Garfield-fr
Acquisition: fix default vendor language
3bae7da 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes rero#2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Sep 21, 2023
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 21, 2023
@Garfield-fr
acquisition: fix default vendor language
4ef62c3 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes rero#2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from Product Backlog to Ready to test in RERO ILS issues Sep 21, 2023
@Garfield-fr Garfield-fr self-assigned this Sep 21, 2023
Garfield-fr added a commit that referenced this issue Sep 28, 2023
@Garfield-fr
acquisition: fix default vendor language
76d6b01 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes #2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Sep 28, 2023
Garfield-fr added a commit that referenced this issue Oct 2, 2023
@Garfield-fr
acquisition: fix default vendor language
1df8631 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes #2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 2, 2023
@Garfield-fr
acquisition: fix default vendor language
9a35084 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes rero#2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Oct 2, 2023
@Garfield-fr
acquisition: fix default vendor language
601a15e 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes #2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Oct 3, 2023
@Garfield-fr
acquisition: fix default vendor language
ab5cf55 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes #2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 3, 2023
@Garfield-fr
acquisition: fix default vendor language
0fc1a2e 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes rero#2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 3, 2023
@Garfield-fr
acquisition: fix default vendor language
479816b 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes rero#2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 3, 2023
@Garfield-fr
acquisition: fix default vendor language
b926e55 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes rero#2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues Oct 3, 2023
Garfield-fr added a commit that referenced this issue Oct 3, 2023
@Garfield-fr
acquisition: fix default vendor language
add6d5f 
If the vendor's communication language is not defined,
we use the default language (eng).

* Closes #2714.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking effort: minor Solved quickly f: acquisitions Related to the acquisition module
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

acquisition: fix default vendor language Garfield-fr/rero-ils
3 participants
@Garfield-fr @ManaDeweerdt @PascalRepond