Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order lines in the notifications are not in the same sequence than in the order detailed view #2653

Closed
pronguen opened this issue Jan 25, 2022 · 0 comments · Fixed by #3463
Closed

Order lines in the notifications are not in the same sequence than in the order detailed view #2653

pronguen opened this issue Jan 25, 2022 · 0 comments · Fixed by #3463
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: notifications

Comments

@pronguen
Copy link
Contributor

pronguen commented Jan 25, 2022 •
edited
Loading

Describe the bug

We have an order with various lines linked to the same document: different volumes are wanted
image

When generating the notification, the lines are not anymore in the same sequence, which is confusing for the vendor.

To Reproduce

  1. Create an order with at least three lines
  2. Send the order
  3. See the preview: the lines are not in the same sequence

Expected behavior

  • In the notification, the lines are in the same sequence than in the order detailed view
  • [nice to have] I can sort the lines by title, date added, priority
    • ideally, I can reorder them manually

Context

  • server: bib.rero.ch
  • version: v1.8.0
@pronguen pronguen added f: notifications bug Breaks something but is not blocking f: acquisitions Related to the acquisition module p-Medium Medium priority (to be solved within 1-2 years) labels Jan 25, 2022
@PascalRepond PascalRepond removed the p-Medium Medium priority (to be solved within 1-2 years) label Mar 30, 2023
@PascalRepond PascalRepond moved this to Product Backlog in RERO ILS issues Mar 30, 2023
@Garfield-fr Garfield-fr moved this from Product Backlog to Sprint backlog in RERO ILS issues Sep 20, 2023
@Garfield-fr Garfield-fr moved this from Sprint backlog to In Development in RERO ILS issues Sep 20, 2023
@Garfield-fr Garfield-fr self-assigned this Sep 20, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 20, 2023
@Garfield-fr
acquisitions: sort lines in order
fc96041 
Line sorting is now done on the PID to keep the same order as the command.

* Closes rero#2653.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Sep 20, 2023
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 20, 2023
@Garfield-fr
acquisitions: sort lines in order
e7e2f87 
Line sorting is now done on the PID to keep the same order as the command.

* Closes rero#2653.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Sep 21, 2023
Garfield-fr added a commit that referenced this issue Sep 28, 2023
@Garfield-fr
acquisitions: sort lines in order
d87cd18 
Line sorting is now done on the PID to keep the same order as the command.

* Closes #2653.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Sep 28, 2023
Garfield-fr added a commit that referenced this issue Oct 2, 2023
@Garfield-fr
acquisitions: sort lines in order
cfd07f7 
Line sorting is now done on the PID to keep the same order as the command.

* Closes #2653.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Oct 2, 2023
@Garfield-fr
acquisitions: sort lines in order
089fce0 
Line sorting is now done on the PID to keep the same order as the command.

* Closes rero#2653.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues Oct 2, 2023
Garfield-fr added a commit that referenced this issue Oct 2, 2023
@Garfield-fr
acquisitions: sort lines in order
8187995 
Line sorting is now done on the PID to keep the same order as the command.

* Closes #2653.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Oct 3, 2023
@Garfield-fr
acquisitions: sort lines in order
05fec77 
Line sorting is now done on the PID to keep the same order as the command.

* Closes #2653.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Oct 3, 2023
@Garfield-fr
acquisitions: sort lines in order
6f90e2e 
Line sorting is now done on the PID to keep the same order as the command.

* Closes #2653.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: notifications
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

acquisitions: sort lines in order Garfield-fr/rero-ils
3 participants
@Garfield-fr @pronguen @PascalRepond