Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix item sorting for standard holdings #2243

Closed
iGormilhit opened this issue Jul 26, 2021 · 2 comments · Fixed by #3461
Closed

Fix item sorting for standard holdings #2243

iGormilhit opened this issue Jul 26, 2021 · 2 comments · Fixed by #3461
Assignees
@Garfield-fr
Labels
client request Issue reported by production libraries enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface UX User experience, ergonomy

Comments

@iGormilhit
Copy link

iGormilhit commented Jul 26, 2021 •
edited by PascalRepond
Loading

How it works

When a holdings (type standard) has a lot of items, the items are not sorted, thus finding a specific item is not an easy task.

Improvement suggestion

The items are sorted by the field unit (enumerationAndChronology) descending (higher unit to smaller unit). This sort should be alphabetical but should sort numbers by their numeric value and not as strings.

Explore the collation keyword ES type: https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-collation-keyword-field.html

This concerns only standard holdings. Serial holdings are already sorted according to another logic.

Screenshot

Example of an holdings (within this document) where the items could be sorted by the unit field value: left pro, right public view

image
@iGormilhit iGormilhit added enhancement Improvement of an existing feature triage p-Medium Medium priority (to be solved within 1-2 years) f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface UX User experience, ergonomy and removed triage labels Jul 26, 2021
@pronguen pronguen changed the title Sort items in a holdings by unit field value Sort standard items in a standard holdings by unit field value Jul 26, 2021
@pronguen pronguen removed the f: public ui Public interface, as opposed to the professional interface label Oct 18, 2021
@pronguen pronguen changed the title Sort standard items in a standard holdings by unit field value Sort standard items in a standard holdings by unit (professional interface) Oct 18, 2021
@PascalRepond

This comment was marked as outdated.

Sign in to view
@PascalRepond PascalRepond changed the title Sort standard items in a standard holdings by unit (professional interface) Improve item sorting in standard holdings Feb 21, 2022
@PascalRepond PascalRepond added the f: public ui Public interface, as opposed to the professional interface label Feb 21, 2022
@pronguen pronguen added the effort: minor Solved quickly label Mar 31, 2022
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Sep 28, 2022
@PascalRepond PascalRepond reopened this May 25, 2023
@PascalRepond PascalRepond removed p-Medium Medium priority (to be solved within 1-2 years) stale Stale or no longer relevant labels May 25, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues May 25, 2023
@PascalRepond PascalRepond added the client request Issue reported by production libraries label May 25, 2023
@PascalRepond PascalRepond changed the title Improve item sorting in standard holdings Fix item sorting for standard holdings Jul 3, 2023
@PascalRepond PascalRepond moved this from Product Backlog to Sprint backlog in RERO ILS issues Jul 4, 2023
@PascalRepond PascalRepond moved this from Sprint backlog to Product Backlog in RERO ILS issues Jul 4, 2023
@PascalRepond PascalRepond removed the effort: minor Solved quickly label Jul 4, 2023
@Garfield-fr Garfield-fr moved this from Product Backlog to Sprint backlog in RERO ILS issues Sep 18, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 19, 2023
@Garfield-fr
items: sorting for standard holdings
0bef27a 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes rero#2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Sep 19, 2023
Merged
@Garfield-fr Garfield-fr moved this from Sprint backlog to In Development in RERO ILS issues Sep 19, 2023
@Garfield-fr Garfield-fr self-assigned this Sep 19, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 20, 2023
@Garfield-fr
items: sorting for standard holdings
e4a15bf 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes rero#2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Sep 20, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 27, 2023
@Garfield-fr
items: sorting for standard holdings
7690ea1 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes rero#2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 28, 2023
@Garfield-fr
items: sorting for standard holdings
93687f6 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes rero#2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Sep 28, 2023
@Garfield-fr
items: sorting for standard holdings
7acc6c9 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes #2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Sep 28, 2023
Garfield-fr added a commit that referenced this issue Oct 2, 2023
@Garfield-fr
items: sorting for standard holdings
738be02 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes #2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues Oct 2, 2023
Garfield-fr added a commit that referenced this issue Oct 2, 2023
@Garfield-fr
items: sorting for standard holdings
6321ad1 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes #2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Oct 3, 2023
@Garfield-fr
items: sorting for standard holdings
01ef2cb 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes #2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Oct 3, 2023
@Garfield-fr
items: sorting for standard holdings
ac9327b 
Items sorting on standard holdings takes into consideration the numerical
values in the character string.

* Closes #2243.
* Fixes noquery configuration on items sort.

⚠️  migration: items reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
client request Issue reported by production libraries enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface UX User experience, ergonomy
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

items: sorting for standard holdings Garfield-fr/rero-ils
4 participants
@Garfield-fr @iGormilhit @pronguen @PascalRepond