Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop making HTTP requests in tests #261

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

mangin
Copy link
Contributor

@mangin mangin commented Apr 3, 2019

Hi someone,
Some tests ignore session, so betamax can't mock requests for these tests. And these tests go to the Internet.

P.S. On my work, we don't allow any test to go to the Internet. So these tests are failed in our environment.

@FelixSchwarz
Copy link

Thank you very much for your patch. Actually the test suite currently fails as two URLs return a 404 and thus breaking the tests. Your patch preserved the resources and ensures the test suite passes again.

Please merge :-)

@mangin
Copy link
Contributor Author

mangin commented Apr 15, 2020

Hi FelixSchwarz..
I can't do it because I'm not an owner. I'm waiting for a merge 1 year...

I see :
All checks have passed
1 successful check
This branch has no conflicts with the base branch
Only those with write access to this repository can merge pull requests.

@mangin
Copy link
Contributor Author

mangin commented Apr 15, 2020

I've sent an email to owner... I hope he will reply soon

@kloczek
Copy link

kloczek commented Oct 25, 2022

This PR no longer applies on top of 0.10.1.

@mangin mangin closed this Oct 31, 2022
@pquentin
Copy link
Contributor

I think it does apply? Otherwise GitHub would have complained. I do plan to merge this soon.

@pquentin pquentin reopened this Oct 31, 2022
@pquentin pquentin changed the title Pass session into some tests Stop making HTTP requests in tests Oct 31, 2022
@pquentin pquentin merged commit 1aff2e6 into requests:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants