Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoclose option to close backend when session closes #162

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Jul 23, 2023

Closes #153. Also see #146

This is enabled by default only for the SQLite backend.

@JWCook JWCook added the enhancement New feature or request label Jul 23, 2023
@JWCook JWCook added this to the v0.9 milestone Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #162 (4f4a3f7) into main (f862e6d) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   94.77%   95.17%   +0.39%     
==========================================
  Files          11       11              
  Lines        1015     1016       +1     
  Branches      181      181              
==========================================
+ Hits          962      967       +5     
+ Misses         38       34       -4     
  Partials       15       15              
Impacted Files Coverage Δ
aiohttp_client_cache/backends/redis.py 98.24% <ø> (+3.24%) ⬆️
aiohttp_client_cache/backends/base.py 96.72% <100.00%> (+1.19%) ⬆️
aiohttp_client_cache/backends/sqlite.py 99.09% <100.00%> (-0.01%) ⬇️
aiohttp_client_cache/session.py 91.11% <100.00%> (+0.20%) ⬆️
aiohttp_client_cache/signatures.py 76.74% <100.00%> (ø)

@JWCook JWCook force-pushed the autoclose branch 3 times, most recently from 5b20123 to 6eb9fb3 Compare July 23, 2023 03:08
@JWCook JWCook marked this pull request as ready for review July 23, 2023 03:16
@JWCook JWCook merged commit 07894b4 into main Jul 23, 2023
@JWCook JWCook deleted the autoclose branch July 23, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak with redis backend when hiredis is installed
1 participant