The "end" event isn't emitted for some responses #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NodeJS wasn't fired because it wasn't emitted on the response object. I encountered this problem when trying to fetch https://profiles.google.com/VoxPelli through JSDom. I tracked it down to being that the response object in this file only emitted "data"-events and no "end"-events. The change here fixed that. (I hope the bonus spelling correction of "because" is okay as well :) )
|
do all the tests still pass? |
|
Tested now and seems like they do |
|
I saw this same problem - attached code fixes it for me (with a GET to https://www.google.com/m8/feeds/contacts/default/full)! |
|
i can't click that link. |
mikeal
added a commit
that referenced
this pull request
Jun 9, 2011
The "end" event isn't emitted for some responses
|
That link was a link that demonstrates the problem. As in: Rolling a new npm version anytime soon? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "end" event that was supposed to be emitted to fix a core bug in NodeJS wasn't fired because it wasn't emitted on the response object.
I encountered this problem when trying to fetch https://profiles.google.com/VoxPelli through JSDom. I tracked it down to being that the response object in this file only emitted "data"-events and no "end"-events. The change here fixed that.
(I hope the bonus spelling correction of "because" is okay as well :) )