Add missing HTTPS options that were not being passed to tunnel #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2015 17:25
Also added test cases in test-tunnel.js
|
You have a few lint errors. Other than that, it looks good at a glance, and I'll do a more detailed review tomorrow. |
nylen
changed the title
This was referenced Jan 27, 2015
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I had to make another pull request - I fudged up when doing a rebase :(
-This change adds some missing HTTPS options that were not being passed to the tunnel module.
-Updated test-tunnel.js to include tests for mutual TLS over HTTP tunnel
This fixes Issue 1259 where the user is prompted for the private key password when performing mutual authentication using a tunnel proxy with a password-protected private key.