Skip to content

Commit

Permalink
updated the setup.py file to fix a couple of copy paste errors. updat…
Browse files Browse the repository at this point in the history
…ed build commands in documentation
  • Loading branch information
ntelfer committed Sep 19, 2018
1 parent 280dc27 commit 64ad956
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
15 changes: 14 additions & 1 deletion docs/building_releases.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Versions
Use Semantic versioning as described [here](https://semver.org/) when releasing any new code.

# Building Wheels
Make sure you have installed wheel with apt then run the commands below
Make sure you have installed wheel with pip
```bash
pip install wheel
```

Then run these commands
```bash
cd path/to/didery/
python3 setup.py sdist bdist_wheel
Expand All @@ -9,6 +17,11 @@ python3 setup.py sdist bdist_wheel
```bash
twine upload dist/*
```
I've run into issues with twine either giving an error about not expecting a bytes like object. This happens if you've installed twine via apt because it's an older version. You need twine >= 1.11.0. Uninstall it with apt and use this:
```bash
pip install twine
python -m twine upload dist/*
```

# Github
After uploading to Pypi make sure to add the release to GitHub by following the instructions [here](https://help.github.com/articles/creating-releases/)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def _unavailable(self, e):
zip_safe=False,
classifiers=[
# complete classifier list: http://pypi.python.org/pypi?%3Aaction=list_classifiers
'Development Status :: 5 - Production/Stable',
'Development Status :: 4 - Beta',
'Intended Audience :: Developers',
'License :: OSI Approved :: Apache Software License',
'Operating System :: Unix',
Expand Down

0 comments on commit 64ad956

Please sign in to comment.