-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2151] Update Stylelint #2153
[#2151] Update Stylelint #2153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work on the updating of NodeJS to version 18!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on @sopa301, definitely agree with disabling the new rules for now and leave those up for discussion (feel free to file a separate issue for that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Will have to trouble you to fix the conflicts before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The following links are for previewing this pull request:
|
Part of #2151.
Proposed commit message
Other information
This was done in a separate PR because:
There's a few new rules that the updated Stylelint has added. I have disabled them for now, and we should discuss which ones to enable. Here's the list:
shorthand-property-no-redundant-values
declaration-empty-line-before
selector-class-pattern
color-function-notation
alpha-value-notation
comment-empty-line-before
property-no-vendor-prefix
selector-pseudo-element-colon-notation
at-rule-empty-line-before
font-family-name-quotes
color-hex-length
scss/at-import-no-partial-leading-underscore
scss/at-import-partial-extension
scss/load-no-partial-leading-underscore
scss/double-slash-comment-empty-line-before
scss/double-slash-comment-whitespace-inside
scss/dollar-variable-pattern