Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2151] Update Stylelint #2153

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Conversation

sopa301
Copy link
Contributor

@sopa301 sopa301 commented Mar 10, 2024

Part of #2151.

Proposed commit message

Update Stylelint

The depreciated rules have been moved to a dedicated plugin. We can now
update our Stylelint linter to the latest version.

Let's do so, as well as update related dependencies.

Other information

This was done in a separate PR because:

  1. It involves breaking changes
  2. It replaces a large part of the Stylelint installation

There's a few new rules that the updated Stylelint has added. I have disabled them for now, and we should discuss which ones to enable. Here's the list:

  • shorthand-property-no-redundant-values
  • declaration-empty-line-before
  • selector-class-pattern
  • color-function-notation
  • alpha-value-notation
  • comment-empty-line-before
  • property-no-vendor-prefix
  • selector-pseudo-element-colon-notation
  • at-rule-empty-line-before
  • font-family-name-quotes
  • color-hex-length
  • scss/at-import-no-partial-leading-underscore
  • scss/at-import-partial-extension
  • scss/load-no-partial-leading-underscore
  • scss/double-slash-comment-empty-line-before
  • scss/double-slash-comment-whitespace-inside
  • scss/dollar-variable-pattern

@sopa301 sopa301 marked this pull request as ready for review March 11, 2024 03:50
@sopa301 sopa301 requested a review from a team March 11, 2024 03:51
Copy link
Contributor

@georgetayqy georgetayqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work on the updating of NodeJS to version 18!

@ckcherry23 ckcherry23 requested a review from a team March 27, 2024 20:14
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @sopa301, definitely agree with disabling the new rules for now and leave those up for discussion (feel free to file a separate issue for that)

frontend/.stylelintrc.json Show resolved Hide resolved
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Will have to trouble you to fix the conflicts before merging

@vvidday vvidday requested a review from a team March 28, 2024 14:15
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

frontend/babel.config.js Outdated Show resolved Hide resolved
@ckcherry23 ckcherry23 merged commit 0f21c65 into reposense:master Apr 18, 2024
8 checks passed
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants