Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1076] Author: Add a isIgnoringFile method #1085

Merged
merged 17 commits into from
Mar 6, 2020
Merged

[#1076] Author: Add a isIgnoringFile method #1085

merged 17 commits into from
Mar 6, 2020

Conversation

anubh-v
Copy link
Contributor

@anubh-v anubh-v commented Feb 15, 2020 •
edited
Loading

Fixes #1076

Author: Add a `isIgnoringFile` method

There are a few instances where we obtain the
ignoreGlobMatcher from an Author instance and then manually
check if this matches with a given file path.

Let's allow the Author instance
to tell clients if it is ignoring a particular file
(given a filepath) - instead of giving clients the
ignoreGlobMatcher and letting clients figure
out the answer on their own.

@anubh-v anubh-v marked this pull request as ready for review February 15, 2020 17:23
@anubh-v anubh-v requested a review from a team February 15, 2020 17:23
jamessspanggg
jamessspanggg approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@jamessspanggg jamessspanggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anubh-v anubh-v removed the request for review from fzdy1914 February 22, 2020 05:14
@anubh-v anubh-v changed the title [#1076] Author: Add a isAuthorIgnoringFile method [#1076] Author: Add a isIgnoringFile method Feb 22, 2020
@anubh-v anubh-v requested a review from a team February 23, 2020 11:23
ccyccyccy
ccyccyccy reviewed Feb 24, 2020
View reviewed changes
Copy link
Contributor

@ccyccyccy ccyccyccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anubh-v anubh-v requested a review from a team February 27, 2020 02:38
@anubh-v
Copy link
Contributor Author

anubh-v commented Mar 6, 2020

@fzdy1914 can this be merged? Thanks very much for your time

@fzdy1914 fzdy1914 merged commit 33e24b8 into reposense:master Mar 6, 2020
Tejas2805 added a commit to Tejas2805/RepoSense that referenced this pull request Mar 13, 2020
@Tejas2805
Merge branch 'refactor-panels-css' of https://github.com/Tejas2805/Re…
af4f816 
…poSense into refactor-panels-css

* 'refactor-panels-css' of https://github.com/Tejas2805/RepoSense:
  [reposense#1109] Config.json: include active author and pug file format (reposense#1123)
  [reposense#1004] Make Code Panel consistent with Chart Panel (reposense#1080)
  [reposense#1005, reposense#1010] Code Panel: match font with GitHub and break lines when overflow (reposense#1008)
  [reposense#1076] Author: add a `isIgnoringFile` method (reposense#1085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccyccyccy ccyccyccy ccyccyccy left review comments

@fzdy1914 fzdy1914 fzdy1914 approved these changes

@jamessspanggg jamessspanggg jamessspanggg approved these changes

@eugenepeh eugenepeh eugenepeh approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Author: Add a isIgnoringFile method
5 participants
@anubh-v @eugenepeh @ccyccyccy @jamessspanggg @fzdy1914