Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Java 11 Syntax and Features #2177

Closed
4 tasks done
georgetayqy opened this issue Mar 28, 2024 · 2 comments
Closed
4 tasks done

Migrate to Java 11 Syntax and Features #2177

georgetayqy opened this issue Mar 28, 2024 · 2 comments

Comments

@georgetayqy
Copy link
Contributor

georgetayqy commented Mar 28, 2024

What feature(s) would you like to see in RepoSense

The current language support on which our codebase is written is based on Java 8. However, we should look into migrating to Java 11 LTS for better security, features and APIs.

EDIT: After checking the API documentation, it appears that the HttpServer implementation introduced in JDK 11 is part of the com.sun package, which is discouraged from use due to the JRE-specific implementation of these packages, meaning that users of other JREs other than openjdk may not be able to use it without breaking. As such, it might not be prudent to change the existing HTTP server packages that we are using right now for the new, implementation-specific HTTP server internal package offered by the JDK.

Is the feature request related to a problem?

Related to #1304.

If possible, describe the solution

We could refer to these websites on the new features introduced in Java 9, Java 10 and Java 11, and evaluate if the new features offered by Java 9, 10 and 11 can be implemented into the current codebase.

If applicable, describe alternatives you've considered

N/A

Additional context

This is potentially a large issue and may require multiple issues and PRs to resolve. The following are tasks that we need to complete to successfully migrate from Java 8 language support to Java 11 language support.

@georgetayqy georgetayqy linked a pull request Apr 2, 2024 that will close this issue
1 task
supermii2 pushed a commit that referenced this issue Apr 27, 2024
* Migrate CI/CD to Java 11

* Update Docs to reflect Java 11

* Update CI JDK version

* Update checkstyle tool

* Revert "Update CI JDK version"

The updating of the Checkstyle tool will be deferred
to another PR to avoid causing dependency issues
arising from backwards compatibility.

* Reapply "Update CI JDK version"

Reapplying revert action as it was reverted on
the wrong commit.

* Revert "Update checkstyle tool"

The updating of the Checkstyle tool will be deferred
to another PR to avoid causing dependency issues
arising from backwards compatibility.

* Remove deprecated flags

---------

Co-authored-by: Ryan Poon <[email protected]>
@georgetayqy
Copy link
Contributor Author

Closing this issue as we have migrated over to Java 11, and have introduced Java 11 syntax that is non-compatible with older versions of Java.

@ckcherry23
Copy link
Member

We can create a new issue for upgrading checkstyle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed/Completed
Development

No branches or pull requests

2 participants