Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it PHP 8.2 compatible #660

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open

Conversation

xvilo
Copy link
Contributor

@xvilo xvilo commented Jul 9, 2023

This branch, branched off from #580. It's that + PHP 8.0 to PHP 8.2 compatibility fixes and updates

xvilo and others added 30 commits April 6, 2022 16:02
This reverts commit 835c2d9.
Co-authored-by: Marcin Michalski <[email protected]>
Co-authored-by: Marcin Michalski <[email protected]>
Co-authored-by: Marcin Michalski <[email protected]>
xvilo and others added 17 commits July 10, 2023 11:00
Added an extra wrapper method around the commands for createAdvisoriesDatabaseRepo
these failed with the default set-up and I couldn't figure out why.

One of the commands failed with a non-zero exit code, thus the others failing to.
This ensures the commands always gets properly executed and otherwise an exception
with extra information is thrown
  The "--no-interaction
  php bin/console messenger:setup-transports" option does not exist.
@xvilo xvilo mentioned this pull request Dec 18, 2023
@xvilo
Copy link
Contributor Author

xvilo commented Dec 18, 2023

Small note, I disabled the repman.io proxy as this seems to be very outdated.

@xvilo xvilo marked this pull request as ready for review December 18, 2023 13:45
@xvilo
Copy link
Contributor Author

xvilo commented Dec 18, 2023

Tests: 500, Assertions: 1185, Errors: 2, Failures: 6, Risky: 1.

Dockerfile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants