Dependency/dependant tracking

[giggsey]

Show package dependencies in detail view, linking to other packages known in the same organisation.

Allow searching for other packages that depend on this package (count is shown on the details view):

Fixes #175

[giggsey]

Plenty to do on this, but I want to get some feedback on the structure and the future UI

Annoyingly, my thinking is pretty much the same as Packagist. Showing the actual dependencies above the README. Then maybe a separate package list on a separate page, linked under Actions.

Maybe the dependant list is a special search (depends:giggsey/locale)

[akondas]

1. Wow, nice work 👍
2. Would you be able to add a screenshot of what it looks like?
3. Ok, now I understand why a separate table. I wonder how it will affect the performance with a large number of packages, but postgres should handle it, I think you can go ahead and continue 👍

[giggsey]

I need ideas for the design. At the moment, it's just using flexbox with wrapped columns.

A 'full' package containing all types:

A package with minimal data:

(ignore the duplicate require + requires, I haven't done the purging yet)

[giggsey]

Now:

[giggsey]

I'm not that familiar with doctrine, and it's complaining about the schema not matching the mapping files.

Any ideas @akondas?

Apart from that, the tests should be passing, and it should be ready for review. I've updated the top comment with the latest screenshots/features.

[akondas]

So, you can run bin/console d:m:diff to check what's changed. From your branch:

    public function up(Schema $schema) : void
    {
        // this up() migration is auto-generated, please modify it to your needs
        $this->addSql('ALTER TABLE organization_package_link ADD CONSTRAINT FK_4A06082932C8A3DE FOREIGN KEY (organization_id) REFERENCES organization (id) NOT DEFERRABLE INITIALLY IMMEDIATE');
        $this->addSql('CREATE INDEX IDX_4A06082932C8A3DE ON organization_package_link (organization_id)');
    }

    public function down(Schema $schema) : void
    {
        // this down() migration is auto-generated, please modify it to your needs
        $this->addSql('ALTER TABLE organization_package_link DROP CONSTRAINT FK_4A06082932C8A3DE');
        $this->addSql('DROP INDEX IDX_4A06082932C8A3DE');
    }

Besides, the whole thing looks very good, when you're done, let me know, I'll click through it and we'll make a new release 🎉

[giggsey]

Migration now failing due to:

[notice] Migrating up to Buddy\Repman\Migrations\Version20210401061218
[warning] Migration Buddy\Repman\Migrations\Version20200720112146 was executed but did not result in any SQL statements.
[error] Migration Buddy\Repman\Migrations\Version20210401061218 failed during Execution. Error: "An exception occurred while executing 'ALTER TABLE organization_package_link ADD CONSTRAINT FK_4A06082932C8A3DE FOREIGN KEY (organization_id) REFERENCES organization (id) NOT DEFERRABLE INITIALLY IMMEDIATE':

However, this file doesn't exist?

[akondas]

Hey @giggsey it was my fault, sorry. When I debugged the previous pipeline, I forgot to remove the generated migration. Anyway, there are still some differences:

$this->addSql('ALTER INDEX link_organization_id_idx RENAME TO IDX_4A06082932C8A3DE');

[giggsey]

Thanks @akondas.

That index is currently generated via:

        $this->addSql('CREATE INDEX link_organization_id_idx ON organization_package_link (organization_id)');

I can rename it there, but how does that automatic name get generated when it's fine for the 'link_package_id_idx' index?

[akondas]

As far as I remember, this name is generated by doctrine, based on mappings:

    /**
     * @ORM\ManyToOne(targetEntity="Buddy\Repman\Entity\Organization")
     * @ORM\JoinColumn(nullable=false)
     */

Maybe you had an older version, or you made it out of your finger? it's hard for me to figure out why this name is wrong ... 🤔

[codecov]

Codecov Report

Merging #426 (8fa3e95) into master (507a4bb) will decrease coverage by 0.04%.
The diff coverage is 97.16%.

@@             Coverage Diff              @@
##             master     #426      +/-   ##
============================================
- Coverage     99.38%   99.34%   -0.05%     
- Complexity     1864     1891      +27     
============================================
  Files           297      298       +1     
  Lines          5873     5969      +96     
============================================
+ Hits           5837     5930      +93     
- Misses           36       39       +3     

Impacted Files	Coverage Δ	Complexity Δ
src/Query/User/PackageQuery/Filter.php	95.83% <83.33%> (-4.17%)	10.00 <4.00> (+4.00)	⬇️
src/Entity/Organization/Package/Link.php	91.30% <91.30%> (ø)	9.00 <9.00> (?)
src/Controller/OrganizationController.php	100.00% <100.00%> (ø)	44.00 <0.00> (+2.00)
src/Entity/Organization/Package.php	100.00% <100.00%> (ø)	43.00 <7.00> (+4.00)
src/Query/User/PackageQuery/DbalPackageQuery.php	100.00% <100.00%> (ø)	35.00 <2.00> (+4.00)
...ackageSynchronizer/ComposerPackageSynchronizer.php	97.81% <100.00%> (+0.35%)	39.00 <0.00> (+4.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507a4bb...8fa3e95. Read the comment docs.

[akondas]

I tested the whole thing, the user experience is very positive. There is still the question of optimizing the number of database queries to consider.
Great work, and thank you @giggsey 🎖️