Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHPUnit assertions #425

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the assertFileExists to assert expected file path is existed.
  • Using the assertFileNotExists to assert expected file path is not existed.
  • Using the assertIsResource to assert expected type is resource.
  • Using the assertCount to assert expected counter is same as result.

@akondas
Copy link
Member

akondas commented Mar 8, 2021

Thanks for contribution, assertFileNotExists is deprecated, assertFileDoesNotExist should be used instead: sebastianbergmann/phpunit#4077

@peter279k
Copy link
Contributor Author

Thanks for contribution, assertFileNotExists is deprecated, assertFileDoesNotExist should be used instead: sebastianbergmann/phpunit#4077

You're right. I will fix that.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #425 (2d14e1b) into master (3cc224e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #425   +/-   ##
=========================================
  Coverage     99.38%   99.38%           
  Complexity     1864     1864           
=========================================
  Files           297      297           
  Lines          5873     5873           
=========================================
  Hits           5837     5837           
  Misses           36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc224e...2d14e1b. Read the comment docs.

@akondas
Copy link
Member

akondas commented Mar 8, 2021

Thanks 🍻

@akondas akondas merged commit 507a4bb into repman-io:master Mar 8, 2021
@peter279k peter279k deleted the test_enhancement branch March 8, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants