Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: composer 9999999-dev issue #422

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Fix: composer 9999999-dev issue #422

merged 2 commits into from
Mar 2, 2021

Conversation

slappyslap
Copy link
Contributor

@slappyslap slappyslap commented Mar 1, 2021

Closes #421

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #422 (333b131) into master (c50b53e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #422   +/-   ##
=========================================
  Coverage     99.38%   99.38%           
- Complexity     1863     1864    +1     
=========================================
  Files           297      297           
  Lines          5871     5873    +2     
=========================================
+ Hits           5835     5837    +2     
  Misses           36       36           
Impacted Files Coverage Δ Complexity Δ
src/Service/Dist.php 100.00% <100.00%> (ø) 8.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50b53e...333b131. Read the comment docs.

@akondas
Copy link
Member

akondas commented Mar 1, 2021

Thanks for PR, we will check if it does not cause any BC breaks and let you know.

Copy link
Member

@akondas akondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with v1 and v2, everything seems to be working fine.
Thanks for contribution 👍

@akondas akondas merged commit 77fb968 into repman-io:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 404 error when package version is dev-master
2 participants