Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create abstraction for oauth client registry #397

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

akondas
Copy link
Member

@akondas akondas commented Jan 29, 2021

Last part.
Closes #393

@akondas akondas requested a review from karniv00l January 29, 2021 14:34
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #397 (4ac97e8) into master (14460be) will decrease coverage by 0.01%.
The diff coverage is 97.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #397      +/-   ##
============================================
- Coverage     99.51%   99.50%   -0.02%     
- Complexity     1839     1848       +9     
============================================
  Files           295      297       +2     
  Lines          5804     5823      +19     
============================================
+ Hits           5776     5794      +18     
- Misses           28       29       +1     
Impacted Files Coverage Δ Complexity Δ
src/Service/Proxy.php 96.25% <50.00%> (-0.59%) 63.00 <0.00> (+3.00) ⬇️
src/Entity/User/OAuthToken.php 100.00% <100.00%> (ø) 8.00 <5.00> (ø)
...ndler/Organization/Package/AbstractHookHandler.php 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
...r/Organization/Package/AddBitbucketHookHandler.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...dler/Organization/Package/AddGitHubHookHandler.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...dler/Organization/Package/AddGitLabHookHandler.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...rganization/Package/RemoveBitbucketHookHandler.php 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...r/Organization/Package/RemoveGitHubHookHandler.php 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...r/Organization/Package/RemoveGitLabHookHandler.php 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...ackageSynchronizer/ComposerPackageSynchronizer.php 98.23% <100.00%> (ø) 33.00 <0.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14460be...4ac97e8. Read the comment docs.

@karniv00l karniv00l merged commit 6c01dce into repman-io:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove RefreshOAuthTokenMiddleware
2 participants