Repo JSON Performance Improvements #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Any requested package which does not exist MUST return a 404 status code, which will indicate to Composer that this package does not exist in your repository. Make sure the 404 response is fast to avoid blocking Composer. Avoid redirects to alternative 404 pages.
It needs to return the last modified date from the providers to use in the HTTP Response. Also fix minor performance improvement with array_merge
This contains the full list of packages available on the repo. This stops Composer attempting to access the metadata-url for 'public' packages.
The mock wasn't updated to reflect the change in function. However, the tests weren't actually checking the scan was working.
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=========================================
Coverage 99.50% 99.50%
Complexity 1838 1838
=========================================
Files 295 295
Lines 5802 5802
=========================================
Hits 5773 5773
Misses 29 29 Continue to review full report at Codecov.
|
|
Thanks again @giggsey for your work 🎖️ 🍻. |
|
I would also like to congratulate you on your commit descriptions. They are first-rate 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #308