Replace all pagination with Filter classes #263
Conversation
Signed-off-by: Joshua Gigg <[email protected]>
Continuation of #259
|
I force pushed to try to get rid of some of the unrelated commits, but I think the pipeline is from before. CS Fixer runs fine locally |
|
Both PHPStan failures are because |
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
============================================
- Coverage 99.82% 99.80% -0.03%
- Complexity 1539 1542 +3
============================================
Files 252 253 +1
Lines 4479 4503 +24
============================================
+ Hits 4471 4494 +23
- Misses 8 9 +1
Continue to review full report at Codecov.
|
| @@ -144,7 +143,7 @@ public function versionCount(string $packageId): int | |||
| /** | |||
| * @return Version[] | |||
| */ | |||
| public function getVersions(string $packageId, int $limit = 20, int $offset = 0): array | |||
| public function getVersions(string $packageId, \Buddy\Repman\Query\Filter $filter): array | |||
There was a problem hiding this comment.
I wonder if we can somehow automate the detection of this notation?
There was a problem hiding this comment.
Possibly 'fully_qualified_strict_types', but it looks like that only works when the use statement is there in the first place
|
Thanks @giggsey for your work 🍻 |
Continuation of #259