Serve static proxy metadata and use v2 endpoint for dist lookup #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## static-proxy #222 +/- ##
==================================================
- Coverage 99.73% 99.70% -0.03%
+ Complexity 1440 1404 -36
==================================================
Files 234 233 -1
Lines 4092 4039 -53
==================================================
- Hits 4081 4027 -54
- Misses 11 12 +1
Continue to review full report at Codecov.
|
akondas
commented
Jul 16, 2020
| @@ -342,14 +342,6 @@ public function packageScanResults(Organization $organization, Package $package, | |||
| ]); | |||
| } | |||
|
|
|||
| protected function getUser(): User | |||
akondas
commented
Jul 16, 2020
| @@ -46,27 +46,28 @@ public function testProviderAction(): void | |||
| "buddy-works/repman": "@array@" | |||
| } | |||
| } | |||
| ', $this->client->getResponse()->getContent()); | |||
| ', $response); | |||
| self::assertTrue($this->client->getResponse()->isCacheable()); | |||
There was a problem hiding this comment.
this will allow us to let others use their cache as well
8 tasks
karniv00l
approved these changes
Jul 16, 2020
akondas
added a commit
that referenced
this pull request
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.