Optimise delete query

repman-io · Aug 14, 2020 · 825ab3f · 825ab3f
1 parent 0ba6a4d
commit 825ab3f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 34 deletions.
diff --git a/src/Repository/VersionRepository.php b/src/Repository/VersionRepository.php
@@ -25,12 +25,11 @@ public function __construct(ManagerRegistry $registry)
 
     public function remove(UuidInterface $id): void
     {
-        $version = $this->find($id);
-        if (!$version instanceof Version) {
-            throw new \InvalidArgumentException(sprintf('Version %s not found.', $id->toString()));
-        }
-
-        $this->_em->remove($version);
-        $this->_em->flush();
+        $this->_em->createQueryBuilder()
+            ->delete(Version::class, 'v')
+            ->where('v.id = :id')
+            ->setParameter('id', $id)
+            ->getQuery()
+            ->execute();
     }
 }
diff --git a/tests/Integration/Repository/VersionRepositoryTest.php b/tests/Integration/Repository/VersionRepositoryTest.php