Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Adding nodejs package alias mapping #276

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

blast-hardcheese
Copy link
Collaborator

@blast-hardcheese blast-hardcheese commented Aug 2, 2024

Why

Similar to Python, there are some packages that need overriding. To start, tsc, which emits the following if you install it by accident:

image

What changed

  • Introduced new mappings for npmjs.com as well as yarnpkg.com
  • Altered the different Javascript packagers to consider these overrides when doing add or grab

Test plan

upm add tsc should install typescript instead:

$ upm add tsc
--> bun add typescript
bun add v1.0.18 (36c316a2)

 installed [email protected] with binaries:
  - tsc
  - tsserver


 1 package installed [555.00ms]

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner August 2, 2024 22:50
@blast-hardcheese blast-hardcheese requested review from cdmistman and removed request for a team August 2, 2024 22:50
@blast-hardcheese blast-hardcheese merged commit eb8e0d2 into main Aug 2, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/nodejs-package-alias-overrides branch August 2, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants