Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 -> V2a, pool fix, consistent ordering #212

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

bwlang
Copy link
Contributor

@bwlang bwlang commented Feb 4, 2022

  • correct pool identification for primers , all odd -> nCoV-2019_1, all e…ven to nCoV-2019_2
  • updates to VarSkip v2a to correctly match shipped primer mix
  • consistent ordering of tsv primer list

…ven to nCoV-2019_2, updates to VarSkip v2a to correctly match shipped primer mix, consistent ordering of tsv primer list
@replikation
Copy link
Owner

replikation commented Feb 4, 2022

  • @bwlang is the official name "VarSkipV2a" instead of "VarSkipV2" ? just to avoid confusion for users.
    and thanks

@bwlang
Copy link
Contributor Author

bwlang commented Feb 4, 2022

The official name is "VarSkip Short v2". The "a" suffix is there to avoid confusion with the old version of the file and make it easy for people to know that they they are using the correct file. I hope we won't need a "b".

@replikation
Copy link
Owner

okay ill merge and keep the current VarSkip2 name. thanks

@replikation replikation merged commit b1be565 into replikation:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants