Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nextclade aa insertions #198

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

RaverJay
Copy link
Collaborator

Implements #189

  • removed my custom solution
  • bumped version of pangolin/nextclade containers, but:
  • no new nextclade release yet, so will not work even with --update
  • should work when it is released, and will add a new version bump

@RaverJay
Copy link
Collaborator Author

@replikation please build a nextclade 1.10 container :)

@RaverJay RaverJay requested a review from replikation January 26, 2022 08:22
@RaverJay
Copy link
Collaborator Author

Thinking of adding the frameshift column to this PR (#199)

With a big red warning if any frameshifts were found:
image

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 26, 2022

@RaverJay I like this disclaimer alert message. I would maybe write "This error can cause masking of downstream ..."

Because tools such as pangolin, covSonar, ... can actually deal w/ most frameshifts and still correctly call the downstream changes. Thats also why were still able to assign Omicron BA.1 w/ high confidence via pangolin although the report only showed one amino acid change in spike based on the Nextstrain output. :)

I wonder if we should simply report Frameshifts on nucleotide level and not only spike? Otherwise, the alert message is shown but then no sequence is obviously marked as having a frameshift. E.g. lets say the frameshift is in the ORF1a or so?

@RaverJay
Copy link
Collaborator Author

Data shown is not limited to spike only, if others were there they would be shown (the brackets only explain that purple means spike)

Nextclade gives frameshifts only on AA level

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 26, 2022

Data shown is not limited to spike only, if others were there they would be shown (the brackets only explain that purple means spike)

Nextclade gives frameshifts only on AA level

Ah true, the Spike ones are just highlighted you're right.

ad Nextclade FS only on AA lvl: ah k, then it's like that

@replikation replikation merged commit 469130a into replikation:master Jan 27, 2022
@RaverJay RaverJay deleted the use_nextclade_aaInsertions branch January 27, 2022 12:39
@RaverJay RaverJay restored the use_nextclade_aaInsertions branch January 27, 2022 13:58
@RaverJay
Copy link
Collaborator Author

RaverJay commented Jan 27, 2022

Mistake on my part, I forgot to push the latest changes (warning message and frameshift column) to the branch, so its not included in the merge

New PR is up #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants