-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nextclade aa insertions #198
Use nextclade aa insertions #198
Conversation
@replikation please build a nextclade 1.10 container :) |
Thinking of adding the frameshift column to this PR (#199) |
@RaverJay I like this disclaimer alert message. I would maybe write "This error can cause masking of downstream ..." Because tools such as pangolin, covSonar, ... can actually deal w/ most frameshifts and still correctly call the downstream changes. Thats also why were still able to assign Omicron BA.1 w/ high confidence via pangolin although the report only showed one amino acid change in spike based on the Nextstrain output. :) I wonder if we should simply report Frameshifts on nucleotide level and not only spike? Otherwise, the alert message is shown but then no sequence is obviously marked as having a frameshift. E.g. lets say the frameshift is in the ORF1a or so? |
Data shown is not limited to spike only, if others were there they would be shown (the brackets only explain that purple means spike) Nextclade gives frameshifts only on AA level |
Ah true, the Spike ones are just highlighted you're right. ad Nextclade FS only on AA lvl: ah k, then it's like that |
Mistake on my part, I forgot to push the latest changes (warning message and frameshift column) to the branch, so its not included in the merge New PR is up #205 |
Implements #189