-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile cleanup and singularity implementation #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gj as always...
ehm there is one comment for basic under standing what you did with the config files
I really like the merged profile structure you came up with @replikation ! Looks really clean. I will also go through the code now. Some general things I observed: Running locally with only
|
@martin i like the With this, we can control more easily the user input and its clearer. ill add that to this PR and if it's working then ill do the merge |
Great, Yeah I was also thinking about this setup again and I only see advantages. Will be also more easy to write error mssgs then and to control User input. |
Backend cleanup
profile changes
-profile
local
(tested) andlsf
(untested) hope @hoelzer can check thatdocker
(tested) andsingularity
(tested)-profile local,docker
or-profile lsf,singularity
etc.