Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub ready and working #139

Merged
merged 8 commits into from
Aug 23, 2021
Merged

stub ready and working #139

merged 8 commits into from
Aug 23, 2021

Conversation

mult1fractal
Copy link
Collaborator

  • included stub statements to relevant modules
  • stub works
  • channels are correct

@replikation
Copy link
Owner

replikation commented Aug 17, 2021

@mult1fractal if stub is working please add it to the gitaction workflow as a dry run

  • use this code as a reference, otherwise the stub is a bit pointless without it link

€ you can replace the currently yml file with this dryrun

@replikation replikation self-requested a review August 17, 2021 12:39
nextflow.config Outdated Show resolved Hide resolved
Copy link
Owner

@replikation replikation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add into the stub genome this so its not an empty file:

> stubgenome
ATGC

@mult1fractal
Copy link
Collaborator Author

I will merge it bc in my poreCov rework the annotation part will get a new layout as discussed, so the score based chunking will be exchanged by "how many tools match per contig" and this will then replace the score based chunking (which currently fails the --annotate syntax check)

@mult1fractal mult1fractal merged commit e8cb10b into master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants