Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload.maximumLimit #626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Andarist
Copy link
Member

No description provided.

@Andarist Andarist requested a review from bvaughn July 11, 2024 13:16
Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 8f402c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@replayio/cypress Minor
@replayio/playwright Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

replay-io bot commented Jul 11, 2024

Status Complete ↗︎
Commit d1e3354
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @@ -364,6 +365,12 @@ export default class ReplayReporter<
    if (typeof config.upload === "object") {
    this._minimizeUploads = !!config.upload.minimizeUploads;
    this._uploadStatusThreshold = config.upload.statusThreshold ?? "all";
    if (typeof config.upload.maximumLimit === "number") {
    if (!Number.isFinite(config.upload.maximumLimit) || config.upload.maximumLimit <= 0) {
    throw new Error("`upload.maximumLimit` must be a finite number higher than 0");
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    nit: "a finite number higher than 0" is technically correct but kind of stuffy. Maybe something more like?

    Suggested change
    throw new Error("`upload.maximumLimit` must be a finite number higher than 0");
    throw new Error("`upload.maximumLimit` must be greater than 0; to disable uploads entirely, set `upload` to false");

    @@ -763,6 +770,9 @@ export default class ReplayReporter<
    });
    return;
    }
    if (this._uploadedRecordings.size >= this._uploadMaxLimit) {
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I don't see us accounting for the number of shards here. That seems important?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants