Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored async initialization logic for Mixpanel, Grafana, and Launch Darkly #624

Merged
merged 10 commits into from
Jul 15, 2024

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 10, 2024

  • Consolidate initialization logic for MixPanel, LaunchDarkly, Grafana, and the user agent string.
  • More consistent handling of tasks that should await authentication (and be flushed before exit)
  • Minor code reorganization to (hopefully) improve readability/clarity

As part of this tidying up, I also changed the login command to show whoami information after a successful sign-in:

Screenshot 2024-07-15 at 11 07 13 AM

Or if you try to log in when you're already authenticated via API key:

Screenshot 2024-07-15 at 11 07 39 AM

Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: 30c335f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@replayio/cypress Patch
@replayio/jest Patch
@replayio/playwright Patch
@replayio/puppeteer Patch
replayio Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

replay-io bot commented Jul 10, 2024

Status Complete ↗︎
Commit c355356
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @bvaughn
    Copy link
    Contributor Author

    bvaughn commented Jul 10, 2024

    /release-pr -> 0.0.0-pr624-20240710193747

    @bvaughn
    Copy link
    Contributor Author

    bvaughn commented Jul 10, 2024

    These auto-generated changeset file names.. 🤔
    Screenshot 2024-07-10 at 3 57 50 PM

    @Andarist
    Copy link
    Member

    The computers have spoken.

    @bvaughn bvaughn marked this pull request as ready for review July 15, 2024 17:26
    @bvaughn bvaughn merged commit 82852c2 into main Jul 15, 2024
    7 checks passed
    @bvaughn bvaughn deleted the PRO-797 branch July 15, 2024 17:26
    @github-actions github-actions bot mentioned this pull request Jul 11, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants