Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install stack-utils to all packages that inline the shared folder #594

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

miriambudayr
Copy link
Contributor

@miriambudayr miriambudayr commented Jul 3, 2024

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: a2e3d56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@replayio/test-utils Patch
@replayio/puppeteer Patch
replayio Patch
@replayio/cypress Patch
@replayio/replay Patch
@replayio/jest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@miriambudayr miriambudayr requested a review from bvaughn July 3, 2024 19:58
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve! but with a change suggested

package.json Outdated
@@ -41,5 +42,8 @@
"@jest/environment@npm:^27.5.1": "patch:@jest/environment@npm%3A28.1.3#~/.yarn/patches/@jest-environment-npm-28.1.3-506a81a227.patch",
"@jest/environment@npm:^28.1.3": "patch:@jest/environment@npm%3A28.1.3#~/.yarn/patches/@jest-environment-npm-28.1.3-506a81a227.patch",
"superstruct": "patch:superstruct@npm%3A1.0.4#~/.yarn/patches/superstruct-npm-1.0.4-44d328b887.patch"
},
"dependencies": {
"stack-utils": "^2.0.6"
Copy link
Contributor

@bvaughn bvaughn Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to (or should?) add this to the root package.json. That's a private package anyway so it won't be published anywhere.

We probably should add it to the one in packages/replay though (even if we don't plan any more releases of this project)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link

replay-io bot commented Jul 3, 2024

Status Complete ↗︎
Commit 77daf44
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @bvaughn bvaughn self-requested a review July 3, 2024 20:12
    Copy link
    Contributor

    @bvaughn bvaughn left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think this looks right. If CI is happy we can test it quickly before publishing.

    @bvaughn
    Copy link
    Contributor

    bvaughn commented Jul 3, 2024

    /release-pr

    @bvaughn
    Copy link
    Contributor

    bvaughn commented Jul 3, 2024

    Don't forget to add a changeset file to this PR so this change will be picked up by all of the packages you've updated.

    Once that's done we should be unblocked to merge this, and then merge the "Versions" PR that will be auto-opened.

    @miriambudayr miriambudayr merged commit 78f5c72 into main Jul 3, 2024
    6 checks passed
    @miriambudayr miriambudayr deleted the mbudayr/missing-dependencies branch July 3, 2024 20:40
    @github-actions github-actions bot mentioned this pull request Jul 3, 2024
    @@ -57,6 +58,7 @@
    "p-map": "^4.0.0",
    "semver": "^7.5.2",
    "sha-1": "^1.0.0",
    "stack-utils": "^2.0.6",
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    this should catch such issues early:

    if (!source.startsWith(".") && !source.startsWith("/") && !isExternal(source)) {
    throw new Error(
    `"${source}" is imported ${
    importer ? `by "${importer}" ` : ""
    }but the package is not specified in dependencies or peerDependencies`
    );
    }

    I wonder why it didn't let us know about it here... I'll investigate tomorrow

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants