Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the log level and message for replayio logs #582

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Conversation

callingmedic911
Copy link
Contributor

  • Registers new exit task to close logger.
  • Change log messages to the convention we are following at other places.
  • Update log level

Copy link

changeset-bot bot commented Jul 1, 2024

⚠️ No Changeset found

Latest commit: 9909c5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

replay-io bot commented Jul 1, 2024

Status Complete ↗︎
Commit 9906b16
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @bvaughn
    Copy link
    Contributor

    bvaughn commented Jul 1, 2024

    Once you've fixed that we should generate a pre-release candidate for this branch so that @Domiii can run it and see if it gives us any more insights into why record is failing for him.

    @callingmedic911 callingmedic911 requested a review from bvaughn July 1, 2024 20:07
    Copy link
    Contributor

    @bvaughn bvaughn left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I defer to @miriambudayr about the specific log levels but I think this makes sense to me fwiw

    @callingmedic911
    Copy link
    Contributor Author

    callingmedic911 commented Jul 1, 2024

    /release-pr: 0.0.0-pr582-20240701201419 use newer release below.

    @callingmedic911
    Copy link
    Contributor Author

    callingmedic911 commented Jul 1, 2024

    /release-pr: 0.0.0-pr582-20240701202835

    @callingmedic911 callingmedic911 merged commit 6413d6b into main Jul 2, 2024
    7 checks passed
    @callingmedic911 callingmedic911 deleted the PRO-705 branch July 2, 2024 15:00
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants