-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mixpanel to Playwright #577
Conversation
|
7a30362
to
e8e54a1
Compare
/release-pr -> 0.0.0-pr577-20240701192536 |
packageName, | ||
packageVersion, | ||
}), | ||
mixpanelAPI.initialize({ accessToken, packageName, packageVersion }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not directly related to this PR - but since the logger initialization is grouped together with the mixpanel's initialization in our test plugins it could also make sense to move that into this [...]/initialize.ts
file here
logger.info("OnTestSuiteBegin:NoApiKey"); | ||
|
||
mixpanelAPI.trackEvent("test-suite.no-api-key"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: couldn't we use a single naming scheme for both of those "loggers"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we could but I don't know if there's value in doing that. They're tracking different things. Sometimes they'll line up (like here) but often they won't. Standardizing on names is work/effort.
playwright
andtest-utils
packages