Rework the dts generation

[Andarist]

fixes https://linear.app/replay/issue/PRO-740

[changeset-bot]

⚠️ No Changeset found

Latest commit: 77a3aae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[replay-io]

Status	Complete ↗︎
Commit	4dc1443
Results	❌ 2 Failed clicks a disappearing button should fail on this test ✅ 42 Passed adds items adds new items using a custom command adds todos following the fixture adds todos following the fixture adds todos following the fixture adds todos following the fixture calls inform complete all checkbox should update state when items are completed / cleared gets a number only gets a number only gets a number should allow me to add todo items should allow me to clear the complete state of all items should allow me to display active items should allow me to display all items should allow me to display completed items should allow me to edit an item should allow me to mark all items as completed should allow me to mark items as complete should allow me to un-mark items as complete should append new items to the bottom of the list should be hidden when there are no items that are completed should cancel edits on escape should clear text input field when an item is added should display the correct text should display the current number of todo items should focus on the todo input field should hide #main and #footer should hide other controls when editing should highlight the currently applied filter should intercept postman should invoke some commands that have exceptional option handling should log should persist its data should remove completed items when clicked should remove the item if an empty text string was entered should respect the back button should save edits on blur should show #main and #footer when items added should trim entered text should trim text input yields a number

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@typescript/[email protected]	environment, network	0	233 kB	typescript-deploys

🚮 Removed packages: npm/@rollup/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[Andarist]

We get a confusing error if a transitive bundled dependency isn't declared here. While we need this situation to error for regular external dependencies, I think we could compute potential bundled dependencies recursively here:

replay-cli/scripts/pkg-build/src/bin.ts

Lines 29 to 33 in 229636e

	const isBundledDependency = makePackagePredicate(
	Object.keys(pkg.packageJson.devDependencies || {}).filter(
	name => packagesByName.has(name) && !isExternal(name)
	)
	);

I imagine that this recursive search should include dependencies (unlike the top-level one above that looks at devDependencies)

[bvaughn]

Stamping to unblock but didn't really read this.

[Andarist]

I think we should consolidate this into a single call and maybe even consider calling those at the top-level. We don't need to wait for the constructor's call here.

I don't intend to touch this as part of this PR though.