Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cli-multipart-upload flag #566

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove cli-multipart-upload flag #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/replay/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,7 @@ async function doUploadRecording(

let recordingId: string;
try {
const isMultipartEnabled = await getLaunchDarkly().isEnabled("cli-multipart-upload", false);
if (size > MIN_MULTIPART_UPLOAD_SIZE && isMultipartEnabled) {
if (size > MIN_MULTIPART_UPLOAD_SIZE) {
recordingId = await multipartUploadRecording(
server,
client,
Expand Down
5 changes: 2 additions & 3 deletions packages/replayio/src/utils/recordings/upload/uploadRecording.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,13 @@ export async function uploadRecording(
client: ProtocolClient,
recording: LocalRecording,
options: {
multiPartUpload: boolean;
processingBehavior: ProcessingBehavior;
}
) {
const { buildId, id, path } = recording;
assert(path, "Recording path is required");

const { multiPartUpload, processingBehavior } = options;
const { processingBehavior } = options;

const { size } = await stat(path);

Expand All @@ -45,7 +44,7 @@ export async function uploadRecording(
recording.uploadStatus = "uploading";

try {
if (multiPartUpload && size > multiPartMinSizeThreshold) {
if (size > multiPartMinSizeThreshold) {
const { chunkSize, partLinks, recordingId, uploadId } = await beginRecordingMultipartUpload(
client,
{
Expand Down
3 changes: 1 addition & 2 deletions packages/replayio/src/utils/recordings/upload/uploadRecordings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export const uploadRecordings = withTrackAsyncEvent(
return [];
}

const multiPartUpload = await getFeatureFlagValue<boolean>("cli-multipart-upload", false);
const client = new ProtocolClient();
try {
await client.waitUntilAuthenticated();
Expand Down Expand Up @@ -70,7 +69,7 @@ export const uploadRecordings = withTrackAsyncEvent(
} else {
return createSettledDeferred<LocalRecording>(
recording,
uploadRecording(client, recording, { multiPartUpload, processingBehavior })
uploadRecording(client, recording, { processingBehavior })
);
}
});
Expand Down