Change logger to singleton

[callingmedic911]

Closes PRO-722.
This PR moves the logger to singleton, we can keep all tags centrally. Will be needed for the sessionId change I'm doing.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 30c49a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[replay-io]

Status	Complete ↗︎
Commit	9aaab05
Results	❌ 2 Failed clicks a disappearing button should fail on this test ✅ 42 Passed adds items adds new items using a custom command adds todos following the fixture adds todos following the fixture adds todos following the fixture adds todos following the fixture calls inform complete all checkbox should update state when items are completed / cleared gets a number only gets a number only gets a number should allow me to add todo items should allow me to clear the complete state of all items should allow me to display active items should allow me to display all items should allow me to display completed items should allow me to edit an item should allow me to mark all items as completed should allow me to mark items as complete should allow me to un-mark items as complete should append new items to the bottom of the list should be hidden when there are no items that are completed should cancel edits on escape should clear text input field when an item is added should display the correct text should display the current number of todo items should focus on the todo input field should hide #main and #footer should hide other controls when editing should highlight the currently applied filter should intercept postman should invoke some commands that have exceptional option handling should log should persist its data should remove completed items when clicked should remove the item if an empty text string was entered should respect the back button should save edits on blur should show #main and #footer when items added should trim entered text should trim text input yields a number

[callingmedic911]

@miriambudayr I had to add, otherwise, the process wasn't exiting packages/puppeteer/src/first-run.ts.

[miriambudayr]

Huh, interesting. So basically the CLI process would hang forever?

[bvaughn]

@Andarist also noticed this -> #570

I'm going to merge and resolve conflicts to unblock this branch from being merged :)

[bvaughn]

Noticed that you're calling close before flush here though. Is that intentional?

If it's important to call both, it seems like flushing before closing would be the expected order. (That's the order @Andarist chose too.)

I'll resolve the conflicts to accept his ordering for now. If that's a mistake, tag me and I'll follow up! 🙇🏼

[Andarist]

Noticed that you're calling close before flush here though. Is that intentional?

I specifically chose to call flush before close so we could await the flush. Close also flushes things but it's using a "detached" promise to do that (it's not returned):
https://github.com/JaniAnttonen/winston-loki/blob/2ed0954e97d85e4be1b81f8d853f1864fa37cf6c/src/batcher.js#L304

[bvaughn]

Nice! Good clarification. (Maybe we should add an inline comment with a link to the docs?)

[bvaughn]

Since Miriam approved this PR, I'm going to merge it. Hope that's okay! (Doing this will unblock me to make a small change to the Logger API to simplify the rest of the work I'm trying to do with PRO-720.)