-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Replay browser to exit before starting a new recording #496
Conversation
🦋 Changeset detectedLatest commit: 3111da5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -0,0 +1,5 @@ | |||
--- | |||
"replayio": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is debatable I guess.
const confirmed = await confirm( | ||
"The replay browser is already running. You'll need to close it before starting a new recording.\n\nWould you like to close it now?", | ||
true | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit conflicted on this proposed behavior but when thinking about it logically... yee, why wouldn't we want to help the user and do it for them if we can? It definitely sounds reasonable. So you have my 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt the same. I didn't intend to do it, but then I thought I probably should
https://www.loom.com/share/1030020be3f241bda470e05dd66cf7aa
cc @cweld510