-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show reason for unusable recording #439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
reviewed
May 6, 2024
packages/replayio/src/utils/recordings/getRecordingUnusableReason.ts
Outdated
Show resolved
Hide resolved
I like the I like the premise of this PR - some information is better than no information. It can both point the user and us in the right direction at times |
bvaughn
force-pushed
the
show-crash-reason
branch
3 times, most recently
from
May 7, 2024 12:14
c05757f
to
3e1b282
Compare
bvaughn
force-pushed
the
show-crash-reason
branch
from
June 3, 2024 12:43
3e1b282
to
a2cd137
Compare
🦋 Changeset detectedLatest commit: b9fbbb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
approved these changes
Jun 3, 2024
bvaughn
force-pushed
the
show-crash-reason
branch
3 times, most recently
from
June 5, 2024 19:43
058459e
to
5eebcb4
Compare
bvaughn
force-pushed
the
show-crash-reason
branch
from
June 5, 2024 19:48
5eebcb4
to
1d35869
Compare
bvaughn
changed the title
Show reason for crashed recording
Show reason for unusable recording
Jun 5, 2024
Andarist
reviewed
Jun 6, 2024
Andarist
reviewed
Jun 6, 2024
Andarist
reviewed
Jun 6, 2024
packages/replayio/src/utils/recordings/getRecordingUnusableReason.ts
Outdated
Show resolved
Hide resolved
Andarist
reviewed
Jun 6, 2024
Andarist
approved these changes
Jun 6, 2024
Co-authored-by: Mateusz Burzyński <[email protected]>
Andarist
reviewed
Jun 6, 2024
Andarist
reviewed
Jun 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves PRO-533
When a recording is marked as unusable, the CLI should report that to the user.