Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show reason for unusable recording #439

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Show reason for unusable recording #439

merged 6 commits into from
Jun 6, 2024

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 6, 2024

Resolves PRO-533

When a recording is marked as unusable, the CLI should report that to the user.

Scenario Screenshot
1 unusable recording Screenshot 2024-06-05 at 3 48 29 PM
1 unusable recording and 1 usable recording Screenshot 2024-06-05 at 3 48 37 PM
1 usable recording Screenshot 2024-06-05 at 3 48 45 PM
multiple usable recordings Screenshot 2024-06-05 at 4 02 48 PM
no new recordings Screenshot 2024-06-05 at 4 04 46 PM

Copy link

replay-io bot commented May 6, 2024

Status Complete ↗︎
Commit cd5957a
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @Andarist
    Copy link
    Member

    Andarist commented May 6, 2024

    I like the I like the premise of this PR - some information is better than no information. It can both point the user and us in the right direction at times

    @bvaughn bvaughn force-pushed the show-crash-reason branch 3 times, most recently from c05757f to 3e1b282 Compare May 7, 2024 12:14
    @bvaughn bvaughn force-pushed the show-crash-reason branch from 3e1b282 to a2cd137 Compare June 3, 2024 12:43
    Copy link

    changeset-bot bot commented Jun 3, 2024

    🦋 Changeset detected

    Latest commit: b9fbbb3

    The changes in this PR will be included in the next version bump.

    This PR includes changesets to release 8 packages
    Name Type
    @replayio/replay Patch
    replayio Patch
    @replayio/cypress Patch
    @replayio/jest Patch
    @replayio/playwright Patch
    @replayio/puppeteer Patch
    @replayio/test-utils Patch
    create-react-app-typescript Patch

    Not sure what this means? Click here to learn what changesets are.

    Click here if you're a maintainer who wants to add another changeset to this PR

    @bvaughn bvaughn force-pushed the show-crash-reason branch 3 times, most recently from 058459e to 5eebcb4 Compare June 5, 2024 19:43
    @bvaughn bvaughn force-pushed the show-crash-reason branch from 5eebcb4 to 1d35869 Compare June 5, 2024 19:48
    @bvaughn bvaughn requested a review from Andarist June 5, 2024 19:49
    @bvaughn bvaughn marked this pull request as ready for review June 5, 2024 19:49
    @bvaughn bvaughn changed the title Show reason for crashed recording Show reason for unusable recording Jun 5, 2024
    @bvaughn bvaughn merged commit 75ee1cb into main Jun 6, 2024
    7 checks passed
    @bvaughn bvaughn deleted the show-crash-reason branch June 6, 2024 13:12
    @github-actions github-actions bot mentioned this pull request Jun 6, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants