Skip to content

Commit

Permalink
Remove cli-multipart-upload flag
Browse files Browse the repository at this point in the history
  • Loading branch information
callingmedic911 committed Jun 25, 2024
1 parent 31a4fbe commit 8030662
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions packages/replay/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,7 @@ async function doUploadRecording(

let recordingId: string;
try {
const isMultipartEnabled = await getLaunchDarkly().isEnabled("cli-multipart-upload", false);
if (size > MIN_MULTIPART_UPLOAD_SIZE && isMultipartEnabled) {
if (size > MIN_MULTIPART_UPLOAD_SIZE) {
recordingId = await multipartUploadRecording(
server,
client,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,13 @@ export async function uploadRecording(
client: ProtocolClient,
recording: LocalRecording,
options: {
multiPartUpload: boolean;
processingBehavior: ProcessingBehavior;
}
) {
const { buildId, id, path } = recording;
assert(path, "Recording path is required");

const { multiPartUpload, processingBehavior } = options;
const { processingBehavior } = options;

const { size } = await stat(path);

Expand All @@ -45,7 +44,7 @@ export async function uploadRecording(
recording.uploadStatus = "uploading";

try {
if (multiPartUpload && size > multiPartMinSizeThreshold) {
if (size > multiPartMinSizeThreshold) {
const { chunkSize, partLinks, recordingId, uploadId } = await beginRecordingMultipartUpload(
client,
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export const uploadRecordings = withTrackAsyncEvent(
return [];
}

const multiPartUpload = await getFeatureFlagValue<boolean>("cli-multipart-upload", false);
const client = new ProtocolClient();
try {
await client.waitUntilAuthenticated();
Expand Down Expand Up @@ -70,7 +69,7 @@ export const uploadRecordings = withTrackAsyncEvent(
} else {
return createSettledDeferred<LocalRecording>(
recording,
uploadRecording(client, recording, { multiPartUpload, processingBehavior })
uploadRecording(client, recording, { processingBehavior })
);
}
});
Expand Down

0 comments on commit 8030662

Please sign in to comment.