Skip to content

Commit

Permalink
Make sure that typecheck is executed on CI (#623)
Browse files Browse the repository at this point in the history
* Make sure that `typecheck` is executed on CI

* break types on purpose

* Revert "break types on purpose"

This reverts commit b616767.

* add turbo to all packages

* add .tsbuildinfo to typecheck outputs
  • Loading branch information
Andarist authored Jul 10, 2024
1 parent 2f6bf31 commit 0bdfaa5
Show file tree
Hide file tree
Showing 14 changed files with 31 additions and 4 deletions.
5 changes: 5 additions & 0 deletions Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ build:
COPY . .
RUN yarn --immutable && yarn run build

typecheck:
FROM +build
RUN yarn run typecheck

lint:
FROM +build
RUN yarn run lint
Expand Down Expand Up @@ -62,6 +66,7 @@ e2e:
BUILD +flake

ci:
BUILD +typecheck
BUILD +lint
BUILD +test
BUILD +e2e
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"watch": "turbo watch build --filter=\"./packages/*\"",
"test": "yarn run test:unit",
"test:unit": "yarn workspaces foreach --all --exclude=. --exclude=examples/create-react-app-typescript --exclude=packages/cypress/example --topological run test",
"typecheck": "yarn workspaces foreach --all run typecheck",
"typecheck": "turbo run typecheck --filter=\"./packages/*\"",
"lint": "prettier --check .",
"changeset": "changeset",
"release": "yarn workspaces foreach --no-private --all --topological npm publish --tolerate-republish --access public && changeset tag",
Expand Down
1 change: 1 addition & 0 deletions packages/cypress/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"@types/uuid": "^9.0.1",
"@types/ws": "^8.5.10",
"cypress": "^13.11.0",
"turbo": "^2.0.5",
"typescript": "^5.5.2"
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/jest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"@replayio/test-utils": "workspace:^",
"@types/node": "^20.11.27",
"@types/stack-utils": "^2.0.3",
"turbo": "^2.0.5",
"typescript": "^5.5.2"
},
"dependencies": {
Expand Down
3 changes: 1 addition & 2 deletions packages/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
"replay-node": "bin/replay-node"
},
"scripts": {
"test": "echo \"Error: no test specified\"",
"typecheck": "echo \"Error: no typecheck specified\""
"test": "echo \"Error: no test specified\""
},
"repository": {
"type": "git",
Expand Down
1 change: 1 addition & 0 deletions packages/playwright/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"@types/stack-utils": "^2.0.3",
"@types/uuid": "^8.3.4",
"@types/ws": "^8.5.10",
"turbo": "^2.0.5",
"typescript": "^5.5.2"
},
"repository": {
Expand Down
1 change: 1 addition & 0 deletions packages/puppeteer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"@replayio/test-utils": "workspace:^",
"@types/node": "^20.11.27",
"@types/stack-utils": "^2.0.3",
"turbo": "^2.0.5",
"typescript": "^5.5.2"
},
"repository": {
Expand Down
1 change: 1 addition & 0 deletions packages/replayio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"jest": "^28.1.3",
"prettier": "^2.7.1",
"ts-jest": "^28.0.6",
"turbo": "^2.0.5",
"typescript": "^5.5.2"
},
"@replay-cli/pkg-build": {
Expand Down
1 change: 1 addition & 0 deletions packages/shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"@types/jest": "^28.1.5",
"@types/stack-utils": "^2.0.3",
"jest": "^28.1.3",
"turbo": "^2.0.5",
"typescript": "^5.5.2"
},
"@replay-cli/pkg-build": {
Expand Down
1 change: 1 addition & 0 deletions packages/sourcemap-upload-webpack-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-prettier": "^3.4.0",
"prettier": "^2.2.1",
"turbo": "^2.0.5",
"typescript": "^5.5.2",
"webpack": "^5.90.3"
},
Expand Down
1 change: 1 addition & 0 deletions packages/sourcemap-upload/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-prettier": "^3.4.0",
"prettier": "^2.2.1",
"turbo": "^2.0.5",
"typescript": "^5.5.2"
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/test-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"@types/debug": "^4.1.7",
"@types/node-fetch": "^2.6.2",
"@types/stack-utils": "^2.0.3",
"turbo": "^2.0.5",
"typescript": "^5.5.2"
},
"@replay-cli/pkg-build": {
Expand Down
7 changes: 6 additions & 1 deletion turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@
"build": {
"dependsOn": ["^build"],
"inputs": ["$TURBO_DEFAULT$", "src/**", "tsconfig.json"],
"outputs": ["dist/**", ".tsbuildinfo"]
"outputs": ["dist/**"]
},
"typecheck": {
"dependsOn": ["^build"],
"inputs": ["$TURBO_DEFAULT$", "src/**", "tsconfig.json"],
"outputs": [".tsbuildinfo"]
}
},
"globalDependencies": ["tsconfig.json"]
Expand Down
9 changes: 9 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3458,6 +3458,7 @@ __metadata:
strip-ansi: "npm:^6.0.1"
superstruct: "npm:^1.0.4"
table: "npm:^6.8.2"
turbo: "npm:^2.0.5"
typescript: "npm:^5.5.2"
undici: "npm:^5.28.4"
winston: "npm:^3.13.0"
Expand Down Expand Up @@ -3517,6 +3518,7 @@ __metadata:
stack-utils: "npm:^2.0.6"
superstruct: "npm:^1.0.4"
terminate: "npm:^2.6.1"
turbo: "npm:^2.0.5"
txml: "npm:^3.2.5"
typescript: "npm:^5.5.2"
undici: "npm:^5.28.4"
Expand Down Expand Up @@ -3557,6 +3559,7 @@ __metadata:
sha-1: "npm:^1.0.0"
stack-utils: "npm:^2.0.6"
superstruct: "npm:^1.0.4"
turbo: "npm:^2.0.5"
typescript: "npm:^5.5.2"
undici: "npm:^5.28.4"
uuid: "npm:^8.3.2"
Expand Down Expand Up @@ -3602,6 +3605,7 @@ __metadata:
sha-1: "npm:^1.0.0"
stack-utils: "npm:^2.0.6"
superstruct: "npm:^1.0.4"
turbo: "npm:^2.0.5"
typescript: "npm:^5.5.2"
undici: "npm:^5.28.4"
uuid: "npm:^8.3.2"
Expand Down Expand Up @@ -3649,6 +3653,7 @@ __metadata:
sha-1: "npm:^1.0.0"
stack-utils: "npm:^2.0.6"
superstruct: "npm:^1.0.4"
turbo: "npm:^2.0.5"
typescript: "npm:^5.5.2"
undici: "npm:^5.28.4"
uuid: "npm:^8.3.2"
Expand Down Expand Up @@ -3706,6 +3711,7 @@ __metadata:
eslint-config-prettier: "npm:^8.3.0"
eslint-plugin-prettier: "npm:^3.4.0"
prettier: "npm:^2.2.1"
turbo: "npm:^2.0.5"
typescript: "npm:^5.5.2"
webpack: "npm:^5.90.3"
peerDependencies:
Expand Down Expand Up @@ -3737,6 +3743,7 @@ __metadata:
p-map: "npm:^4.0.0"
prettier: "npm:^2.2.1"
string.prototype.matchall: "npm:^4.0.5"
turbo: "npm:^2.0.5"
typescript: "npm:^5.5.2"
languageName: unknown
linkType: soft
Expand All @@ -3763,6 +3770,7 @@ __metadata:
sha-1: "npm:^1.0.0"
stack-utils: "npm:^2.0.6"
superstruct: "npm:^1.0.4"
turbo: "npm:^2.0.5"
typescript: "npm:^5.5.2"
undici: "npm:^5.28.4"
uuid: "npm:^8.3.2"
Expand Down Expand Up @@ -15752,6 +15760,7 @@ __metadata:
superstruct: "npm:^1.0.4"
table: "npm:^6.8.2"
ts-jest: "npm:^28.0.6"
turbo: "npm:^2.0.5"
typescript: "npm:^5.5.2"
undici: "npm:^5.28.4"
uuid: "npm:^8.3.2"
Expand Down

0 comments on commit 0bdfaa5

Please sign in to comment.