Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in exception handler #16

Merged
merged 1 commit into from
May 31, 2021
Merged

Fixed bug in exception handler #16

merged 1 commit into from
May 31, 2021

Conversation

hepisec
Copy link
Contributor

@hepisec hepisec commented May 31, 2021

s / Stringy is a class and not a function, therefore the new operator is required.

Fixed bug in exception handler
@repat repat merged commit aef53cd into repat:master May 31, 2021
@repat
Copy link
Owner

repat commented May 31, 2021

Thanks! Actually, I looked into it and decided to get rid of the dependency, as the only function we're using is contains. So I copied the one from laravel/framework over. Assuming not everybody is on PHP 8 and could use the function natively.

@DanMan
Copy link

DanMan commented Jul 15, 2021

…which requires ext-mbstring, which isn't part of your composer.json.

Just use stripos() === false for the check - it's binary safe. You're only trying to find http:// anyway, which doesn't contain any multi-byte characters.

@repat
Copy link
Owner

repat commented Jul 15, 2021

Good point! Changed to stripos in 0.1.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants