Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sign pstb in sats-connect #3288

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Nov 20, 2024

Description

  • Adds signPSBT to SatsConnectConnector

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: b2d98e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:48am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:48am
appkit-laboratory-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:48am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:48am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:48am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:48am

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 378.53999999999996% 5852 / 33971
🔵 Statements 378.53999999999996% 5852 / 33971
🔵 Functions 425% 493 / 1807
🔵 Branches 552.7900000000001% 916 / 2155
File CoverageNo changed files found.
Generated in workflow #7590 for commit b2d98e8 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants