Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Client::certificate_parts() method #72

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

jrconlin
Copy link
Contributor

@jrconlin jrconlin commented May 24, 2023

Description

This was a method that was missed during the initial PR merge. It allows the Client to be built using an imported set of PEM components.

How Has This Been Tested?

A unit test has been added with test cert / key values

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

jrconlin added 2 commits May 24, 2023 16:16
This was a method that was missed during the inital PR merge. It allows
the Client to be built using an imported set of PEM components.
jrconlin added a commit to mozilla-services/autopush-rs that referenced this pull request May 26, 2023
This switches to our updated, but semi-vendored a2 release, while we wait for reown-com/a2#72 to land. 

This should also clear the warning about the included `nom` library.
Cargo.toml Outdated Show resolved Hide resolved
@jrconlin jrconlin requested a review from HarryET June 2, 2023 17:45
Copy link
Contributor

@HarryET HarryET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge and publish next week when I'm back from OOO

@jrconlin
Copy link
Contributor Author

jrconlin commented Jun 5, 2023

No worries, and no rush!

Thank you, again, for taking on this library. Hopefully, that should be the last of the post merge updates.

@HarryET HarryET merged commit 8b38de0 into reown-com:master Jun 5, 2023
@HarryET
Copy link
Contributor

HarryET commented Jun 5, 2023

v0.7.1 has just been published with these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants