Merge with public master #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Why I did it The testcases in sonic-mgmt need the packages of protobuf and dashapi ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Because the docker of sonic-mgmt is based on ubuntu20.04, it cannot directly install the packages compiled by slave due to dependency issues. Download related packaged directly from Azp. #### How to verify it Check azp stats.
- Why I did it BIOS on new generation switch can come with a file type of cap or cab. Needs to add support to these file type. Also ONIE version on new devices can have a suffix of 'dev'. - How I did it Added cap & cab as possible component extensions for ComponentBIOS. Update the ONIE version regex to include dev signed versions. - How to verify it Update BIOS.
…et#15793) - Why I did it The reset cause "reset_from_comex" has been removed by hw-management, hence removing it from platform API code - How I did it Remove reset_from_comex from reboot cause mapping - How to verify it Manual test
= Why I did it To optimize Mellanox platform SAI build - How I did it SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release. - How to verify it Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
…tem health (sonic-net#15289) - Why I did it Adjust PSU power threshold logic in system health. - How I did it Update the description message in PSU power threshold checking power of PSU x (xx w) exceeds threshold (xx w) => System power exceeds xx threshold (xx w) - How to verify it Manual test and unit test
…D automatically (sonic-net#15852) #### Why I did it src/sonic-platform-daemons ``` * 94242c2 - (HEAD -> master, origin/master, origin/HEAD) Use vendor customizable fan speed threshold checks (sonic-net#378) (3 hours ago) [spilkey-cisco] * db6e340 - Fix index out of range in the error log of invalid media lane mask received (sonic-net#386) (8 hours ago) [MichaelWangSmci] ``` #### How I did it #### How to verify it #### Description for the changelog
#### Why I did it Reduced root directory privileges #### How I did it During build_debian - called chroot to reduce root directory and its subdirectories privileges to 744 #### How to verify it After image build and upgrade - check /root privileges by calling "ls -a /root" #### Description for the changelog reduced /root directory privileges
…lly (sonic-net#15860) #### Why I did it src/sonic-swss ``` * 5b27c209 - (HEAD -> master, origin/master, origin/HEAD) Refactor Orch class to separate recorder implementation (sonic-net#2837) (8 hours ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog
…face (sonic-net#15864) sonic-build image side change to fix source interface selection in dual tor scenario. dhcprelay related PR: [master]fix dhcpv6 relay dual tor source interface selection issue sonic-dhcp-relay#42 Announce dhcprelay submodule to 6a6ce24([to invoke #40 PR]([master]fix dhcpv6 relay dual tor source interface selection issue sonic-dhcp-relay#42))
#### Why I did it event yang models for usage currently use int as type for usage leaf, needs to be of type decimal64 ##### Work item tracking - Microsoft ADO **(number only)**:17747466 #### How I did it Update yang models and UT #### How to verify it UT
…5890) Why I did it Fix the armhf build failure. How to reproduce the issue: docker run -it debain:bullseye bash apt-get update && apt-get install -y python3-pip pip3 install PyYAML==5.4.1 Error message: Collecting PyYAML==5.4.1 Installing build dependencies ... done Getting requirements to build wheel ... error ERROR: Command errored out with exit status 1: command: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl .... raise AttributeError(attr) AttributeError: cython_sources ---------------------------------------- WARNING: Discarding https://files.pythonhosted.org/packages/a0/a4/d63f2d7597e1a4b55aa3b4d6c5b029991d3b824b5bd331af8d4ab1ed687d/PyYAML-5.4.1.tar.gz#sha256=607774cbba28732bfa802b54baa7484215f530991055bb562efbed5b2f20a45e (from https://pypi.org/simple/pyyaml/) (requires-python:>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*). Command errored out with exit status 1: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl Check the logs for full command output. ERROR: Could not find a version that satisfies the requirement PyYAML==5.4.1 ERROR: No matching distribution found for PyYAML==5.4.1 root@fa2fa92edcfd:/# But if adding the option --no-build-isolation, then it is good, see fix. install "PyYAML==5.4.1" --no-build-isolation The same error can be found in the multiple builds. Work item tracking Microsoft ADO (number only): 24567457 How I did it Add a build option --no-build-isolation.
…lags in pcied (sonic-net#15896) Why I did it Certain all-numeric device IDs of PCI devices in the pcie.yaml file are left unquoted, leading to false mismatch flags in the pcie daemon and subsequently leads to log flooding. This PR fixes that issue. Work item tracking Microsoft ADO (number only): 24578930 How I did it Added quotes around numeric PCI devices in the pcie.yaml files of the following platforms: x86_64-mlnx_msn2700-r0 x86_64-mlnx_msn4600c-r0 How to verify it Install latest image after the merge and verify that syslogs are not flooded with PCI device mismatch errors
sonic-net#15885) #### Why I did it src/linkmgrd ``` * 6e5cfda - (HEAD -> master, origin/master, origin/HEAD) Change common_libs dependencies from buster to bullseye (sonic-net#212) (2 days ago) [Ze Gan] ``` #### How I did it #### How to verify it #### Description for the changelog
* Update WRED profile on system ports
#### Why I did it [Build] Fix the dash cache dependency issue ``` 12:47:34 [ finished ] [ target/files/bullseye/ctrmgrd.service ] 12:47:36 fatal: Unable to hash src/sonic-dash-api/sonic-dash-api 12:47:36 make: *** [Makefile.cache:528: target/debs/bullseye/libdashapi_1.0.0_amd64.deb.smdep] Error 123 12:47:36 make: *** Waiting for unfinished jobs.... ``` ##### Work item tracking - Microsoft ADO **(number only)**: 24547630
…lly (sonic-net#15908) #### Why I did it src/sonic-swss ``` * cb1b3f40 - (HEAD -> master, origin/master, origin/HEAD) Remove system neighbor DEL operation in m_toSync if SET operation for (sonic-net#2853) (7 hours ago) [Song Yuan] ``` #### How I did it #### How to verify it #### Description for the changelog
…rade ipython to 8.12.2 (sonic-net#15911) Upgrade celery in the python3 to 5.2.7, Upgrade ipython to 8.12.2 since 5.4.1 requires prompt-toolkit<2.0.0,>=1.0.4, But celery 5.2.7 relies click-repl>=0.2.0 , click-repl>=0.2.0 relies prompt-toolkit>=3.0.36. So upgrade ipython to resolve the prompt-toolkit version incompatible issue.
…lly (sonic-net#15921) #### Why I did it src/sonic-gnmi ``` * 610509b - (HEAD -> master, origin/master, origin/HEAD) Install necessary debs instead of entire artifact in azp (sonic-net#137) (2 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Add support for a separate DEB_BUILD_PROFILES environment variable, to be able to set build profiles. This may be used to specify whether python 2 bindings/libraries should be built, or what configuration options should be specified for a package. This also makes it easier to append/remove build profiles from our rules files, which will be needed for the sairedis build. Signed-off-by: Saikrishna Arcot <[email protected]>
* DellEMC: S5248F update LED firmware
Why I did it To fix sonic-net/sonic-mgmt#8786 How I did it Modified Fan API to check whether the data retrieved is valid or not and return accordingly How to verify it Verify whether API 2.0 is loaded properly or not. Execute CLI's like "show version", "show interface status", "show platform psustatus" etc..
…onic-net#15368) * * platform/innoviunm: Add a new supported device and platform, SSE-T7132S * Switch Vendor: Supermicro * Switch SKU: Supermicro_sse_t7132s * ASIC Vendor: innovium * Swich ASIC: TL7 * Port Configuration: 32x400G * SONiC Image: SONiC-ONIE-Innoviunm Signed-off-by: wilsonw <[email protected]>
Add yang model for MUX_LINKMGR|MUXLOGGER.
…lly (sonic-net#16228) #### Why I did it src/sonic-gnmi ``` * ac94807 - (HEAD -> master, origin/master, origin/HEAD) Support get all with json (sonic-net#145) (19 hours ago) [ganglv] ``` #### How I did it #### How to verify it #### Description for the changelog
…sonic-net#16227) #### Why I did it src/dhcpmon ``` * a3c5381 - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #11 from jcaiMR/dev/jcai_fix_err_log (12 hours ago) [StormLiangMS] * ab78a31 - Merge branch 'master' into dev/jcai_fix_err_log (4 days ago) [jcaiMR] * 5314b72 - remove unnessary log message in case too many log output (5 days ago) [jcaiMR] * 01f4fa7 - fix build issue (5 days ago) [jcaiMR] * c2fbb34 - fix format issue (5 days ago) [jcaiMR] * 79b6720 - fix a notification message format issue (6 days ago) [jcaiMR] ``` #### How I did it #### How to verify it #### Description for the changelog
- Why I did it The recent change sonic-net#15685 (comment) removed the db migration for non first reboots. This is problematic for many deployments which doesn't rely on ZTP and push a custom config_db.json Port to older branches after sonic-net#15685 is ported back - How I did it Re-introduce the logic to run the db_migrator on non-first boots - How to verify it Verified reboot and warm-reboot cases Signed-off-by: Vivek Reddy Karri <[email protected]>
…-net#16220) How I did it Update Yang definition of IN_PORTS and OUT_PORTS to string. Since we cannot split the string with comma (,) and validate each substring is a valid SONiC port name. The only restriction for them is must be a string. How to verify it Verified by building sonic_yang_models-1.0-py3-none-any.whl. While building the target package, unit tests were run and passed. Build a SONiC image based on 202205 branch and installed on physical DUT. Re try the steps in [Yang] Incorrect definition of IN_PORTS and OUT_PORTS in sonic-acl.yang sonic-net#16190 and can see below success response:
These devices will not reliabily report the proper devid and vendorid when reading it is read directly from the pci config space. It can be read but shouldn't be compared against some fixed value like the one stored in pcie.yaml. Since this makes pcied unhappy, the simplest path forward is to just remove this device from monitoring.
…6091) - Why I did it watchdogutil uses platform API watchdog instance to control/query watchdog status. In Nvidia watchdog status, it caches "armed" status in a object member "WatchdogImplBase.armed". This is not working for CLI infrastructure because each CLI will create a new watchdog instance, the status cached in previous instance will totally lose. Consider following commands: admin@sonic:~$ sudo watchdogutil arm -s 100 =====> watchdog instance1, armed=True Watchdog armed for 100 seconds admin@sonic:~$ sudo watchdogutil status ======> watchdog instance2, armed=False Status: Unarmed admin@sonic:~$ sudo watchdogutil disarm =======> watchdog instance3, armed=False Failed to disarm Watchdog - How I did it Use sysfs to query watchdog status - How to verify it Manual test Unit test
Why I did it Dell S6100 Platform components needs to be updated. How I did it Modified platform.json to fix the issue. How to verify it Run sonic-mgmt component test and check whether it passes.
Why I did it System health config is missing in few Dell platforms. How I did it Added system health monitoring config and its related API's How to verify it show system-health summary/detail commands.
Ignore intermittent IO errors during get_change_event in the Platform API Fix tunings for some ports on CatalinaDD Fix kernel module build for 6.1 kernel in preparation of bookworm upgrade
### Why I did it When PFC WD is triggered there is no diagnosis information which makes it difficult to understand why PFC WD was triggered. So, we add a field `additional_information` to accommodate the diagnosis information. ### How to verify it unit test
…tomatically (sonic-net#16283) #### Why I did it src/sonic-linux-kernel ``` * a2aa335 - (HEAD -> master, origin/master, origin/HEAD) PATCH] net: allow user to set metric on default route learned via Router Advertisement (sonic-net#326) (12 hours ago) [abdosi] ``` #### How I did it #### How to verify it #### Description for the changelog
…lly (sonic-net#16282) #### Why I did it src/sonic-gnmi ``` * 7a1b7cd - (HEAD -> master, origin/master, origin/HEAD) Improve full path logic (sonic-net#146) (37 minutes ago) [ganglv] ``` #### How I did it #### How to verify it #### Description for the changelog
…#15866) - Why I did it Enabled port late create on SN5600 Spectrum-4 switch boots up with no ports Work item tracking N/A - How I did it Updated SAI xml config file - How to verify it Run sonic-mgmt tests of fastboot Signed-off-by: Nazarii Hnydyn <[email protected]>
…n j2 (sonic-net#16287) Use "{#-" and "-#}" to mark comments in jinja template Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
…-net#15948) - Why I did it Fixed build failure when flag ENABLE_SFLOW_DROPMON=y set - How I did it Fixed sflow dropmon patch to align with hsflowd version 2.0.45 Signed-off-by: rajkumar38 <[email protected]>
How I did it Update Yang definition of ACL_TABLE_TYPE. Update existing testcase. Add new testcase to cover lowercase key scenario. How to verify it Verified by building sonic_yang_models-1.0-py3-none-any.whl. While building the target package, unit tests were run and passed.
…d BMCDATAV6 (sonic-net#16249) Why I did it According to ACL-Table-Type-HLD, the value type of MATCHES, ACTIONS and BIND_POINTS should be list instead of string. Opening this PR to update the definition of BMCDATA and BMCDATAV6. How I did it Update the definition of BMCDATA and BMCDATAV6 in minigraph-parser. How to verify it Verified by UT and build SONiC image.
…et#16188) Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type.
Add yang model for IPv4 DHCP Server. Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT
#### Why I did it To support SKIP_BUILD_HOOK for curl command so the targets downloaded by curl (SONIC_ONLINE_DEBS, SONIC_ONLINE_FILES) can utilize it. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Add a logic to invoke a real command instead of a `download_packages()` (the same way it's done for wget) #### How to verify it Add an online target (with URL attribute). Add the "SKIP_VERSION=y" to this target. Check that download_packages is not invoked.
GouthamBanala
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code update.