Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helmv3): Add support for bumpVersion #7670

Merged
merged 15 commits into from
Nov 10, 2020

Conversation

mikebryant
Copy link
Contributor

@mikebryant mikebryant commented Nov 6, 2020

Changes:

Adds support for bumpVersion to the helmv3 manager

Context:

Part of #4728

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

@mikebryant
Copy link
Contributor Author

The build is currently failing on test coverage - before I dig into trying to add some more tests, can I get a review of the feature itself etc please? :)

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you demonstrate it against an npm example in a public repo to be safe?

lib/config/definitions.ts Outdated Show resolved Hide resolved
@mikebryant
Copy link
Contributor Author

Looks good, can you demonstrate it against an npm example in a public repo to be safe?

Sure, done: https://github.com/mikebryant/renovate-test-helm-lock/pull/4/files

@mikebryant mikebryant requested a review from rarkins November 10, 2020 15:02
@rarkins rarkins merged commit ad50398 into renovatebot:master Nov 10, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mikebryant mikebryant deleted the wip-4728 branch November 10, 2020 22:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants