Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PrResult enum #5664

Merged
merged 9 commits into from
Mar 10, 2020
Merged

feat: PrResult enum #5664

merged 9 commits into from
Mar 10, 2020

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 8, 2020

No description provided.

@rarkins rarkins requested a review from viceice March 8, 2020 15:53
@JamieMagee
Copy link
Contributor

Nice! I am loving the Result pattern.

I have been investigating how we could use this in Renovate, and fp-ts implements it as an Either type

viceice
viceice previously approved these changes Mar 9, 2020
@rarkins rarkins changed the title refactor: PrResult enum feat: PrResult enum Mar 10, 2020
@rarkins rarkins merged commit 34496d3 into master Mar 10, 2020
@rarkins rarkins deleted the refactor/pr-result branch March 10, 2020 08:16
rarkins added a commit that referenced this pull request Mar 10, 2020
commit bef70f7f22dd5a072bab68bdc1c728be92a83260
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 15:29:06 2020 +0100

    mew

commit 09e381c
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 14:58:03 2020 +0100

    fix: Revert "feat(npm): update resolutions (#5636)"

    This reverts commit c974929.

commit ff5fe49
Author: Renovate Bot <[email protected]>
Date:   Tue Mar 10 11:03:11 2020 +0000

    chore(deps): update dependency @types/jest to v25.1.4

commit ae069b0
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 12:00:36 2020 +0100

    fix(github): set stabilityStatus using Enum

    Closes #5683

commit 2599ea5
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 11:24:38 2020 +0100

    refactor: commit -> commitHash

commit c97defc
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 11:11:08 2020 +0100

    refactor: AwaitingBranchAutomerge ->   BlockeddByBranchAutomerge

commit b20591e
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 11:10:09 2020 +0100

    refactor: use CamelCase for enum values

commit d0ec7cf
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 10:19:44 2020 +0100

    refactor: move PrResult to workers/common

commit 2039f17
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 10:02:02 2020 +0100

    refactor: result -> prResult

commit 34496d3
Author: Rhys Arkins <[email protected]>
Date:   Tue Mar 10 09:16:11 2020 +0100

    feat: PrResult enum (#5664)

commit ab94f91
Author: Michael Kriese <[email protected]>
Date:   Tue Mar 10 08:35:31 2020 +0100

    build: fix resolutions (#5681)

commit c974929
Author: Michael Kriese <[email protected]>
Date:   Tue Mar 10 06:52:27 2020 +0100

    feat(npm): update resolutions (#5636)
@rarkins rarkins restored the refactor/pr-result branch August 6, 2020 12:35
@rarkins rarkins deleted the refactor/pr-result branch August 29, 2020 07:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants